Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade controller-runtime from v0.5.0 to v0.6.0 and k8s api from v0.17.2 to v0.18.2 #1483

Closed
wants to merge 1 commit into from
Closed

upgrade controller-runtime from v0.5.0 to v0.6.0 and k8s api from v0.17.2 to v0.18.2 #1483

wants to merge 1 commit into from

Conversation

camilamacedo86
Copy link
Member

Description

  • upgrade controller-runtime from v0.5.0 to v0.6.0
  • k8s api from v0.17.2 to v0.18.2

NOTES: Has breaking changes. See: https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.6.0

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 27, 2020
@camilamacedo86
Copy link
Member Author

/hold

@mengqiy I think we need to move within v3.0.0 as well. WDYT?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 27, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 27, 2020
@camilamacedo86
Copy link
Member Author

camilamacedo86 commented Apr 27, 2020 •
edited

/hold

@mengqiy
Copy link
Member

mengqiy commented May 1, 2020

Please don't check in vendor folder for v1 generated project.

@camilamacedo86
Copy link
Member Author

camilamacedo86 commented May 1, 2020 •
edited

Hi @mengqiy,

When we merge the #1355 I think it will be solved. Because of this, I added the hold.

@camilamacedo86
Copy link
Member Author

We will not able to move forward here until fix the issue faced with the addon.
I am closing this one and raise an issue for we are able to work with

@camilamacedo86 camilamacedo86 deleted the controller-runtime-up-version branch May 3, 2020 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adirio Adirio Awaiting requested review from Adirio

@estroz estroz Awaiting requested review from estroz

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@camilamacedo86 @k8s-ci-robot @mengqiy