-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove update command which was useful just for v1 #1489
feat: remove update command which was useful just for v1 #1489
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c/c @estroz |
HI @estroz, Really tks for your input and help with.
As we spoke, I do not think that we should keep the command at all. See that it is just useful for V1 projects and then, I am afraid that by following your suggestion we will keep a command that has no utility with the justification that we might need or not an updated cmd that works in another way in the future. So, IHMO it shows quite safe be removed. However, let's see if @mengqiy and/or @droot see any reason for we keep it. |
It would be trivial to add back, ex. |
/lgtm |
Description
We no longer need to keep this command to help to migrate the projects to use go mod.
It was useful just to v1 projects which were deprecated to long ago and is no longer supported.
Motivation
Suggestions/comments raised when we remove the v1 code source.