Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the deprecated flags: depArgs and dep. Use fetch-deps instead of them. #1490

Merged

Conversation

camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented May 3, 2020

Description
remove the deprecated flags: depArgs and dep. Use fetch-deps instead of them. See:

if err := fs.MarkDeprecated("dep", "use the fetch-deps flag instead"); err != nil {
	log.Printf("error to mark dep flag as deprecated: %v", err)
}
if err := fs.MarkDeprecated("depArgs", "will be removed with version 1 scaffolding"); err != nil {
	log.Printf("error to mark dep flag as deprecated: %v", err)
}

Motivation
comments/suggestions made when we remove the V1 source code

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 3, 2020
@camilamacedo86
Copy link
Member Author

c/c @estroz

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2020
@estroz
Copy link
Contributor

estroz commented May 4, 2020

@mengqiy can these flags be fully removed for both v2 and v3 projects or just v3?

@camilamacedo86
Copy link
Member Author

camilamacedo86 commented May 5, 2020

Hi @estroz,

V1,V2,V3 are versions related to the project scaffolded layouts and not cli-tool.I mean, to allow breaking changes in the scaffolded projects we need bump a new project/config version.

However, since we will bump an upper version for the next release (3.0.0) then, I understand that we can move forward and remove the args which are deprecated a while for v2 and v3.

@mengqiy please let me know if I misunderstand something here.

@estroz
Copy link
Contributor

estroz commented May 5, 2020

@camilamacedo86 fair point, although we can control what different project versions see in their CLI. I just wasn’t sure whether dep flags were deprecated alongside or independent of v1 deprecation.

@estroz
Copy link
Contributor

estroz commented May 8, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2020
@k8s-ci-robot k8s-ci-robot merged commit 118df81 into kubernetes-sigs:master May 8, 2020
@camilamacedo86 camilamacedo86 deleted the remove-deprecated-flags branch May 8, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants