Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in deleteExternalResources comment #1495

Merged
merged 1 commit into from
Jun 21, 2020

Conversation

n1r1
Copy link
Contributor

@n1r1 n1r1 commented May 6, 2020

I believe the intention was to explain idempotence, so this is just a small typo correction

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 6, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @n1r1!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 6, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @n1r1. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 6, 2020
@camilamacedo86
Copy link
Member

Hi @n1r1,

Tks for your collab. See that the CI is not passing. Mainly you need to assign in the CLA and run make generated to update the testdata with. See the CONTRIBUTION.md doc for a better understanding.

@n1r1
Copy link
Contributor Author

n1r1 commented May 7, 2020

Thanks @camilamacedo86
I've signed the CLA and added the files after make generate

/retest

@k8s-ci-robot
Copy link
Contributor

@n1r1: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

Thanks @camilamacedo86
I've signed the CLA and added the files after make generate

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@n1r1
Copy link
Contributor Author

n1r1 commented May 7, 2020

/check-cla

@n1r1
Copy link
Contributor Author

n1r1 commented May 7, 2020

I signed it

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 8, 2020
@camilamacedo86
Copy link
Member

HI @n1r1,

You need to rebase this on with the master, squash the commits, and ensure that you have the SLA because if it does not pass in the CI is not possible to merge. Could you please check?

@@ -9,5 +9,5 @@ require (
k8s.io/apimachinery v0.17.2
k8s.io/client-go v0.17.2
sigs.k8s.io/controller-runtime v0.5.0
sigs.k8s.io/kubebuilder-declarative-pattern v0.0.0-20200415210853-85eb326a6add
sigs.k8s.io/kubebuilder-declarative-pattern v0.0.0-20200505212709-bc9d91267442
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should not be part of the pr. Could you please rebase with the master?

Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really thank you for your contribution 👍
Could you please rebase it with the master and then, follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

Signed-off-by: Nir <niry@redhat.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 21, 2020
@n1r1
Copy link
Contributor Author

n1r1 commented Jun 21, 2020

@camilamacedo86 , I've signed the CLA and rebased with master.
make generate didn't yield any changes this time, but make check-testdata passed on my end. I hope this is okay.

Let me know if anything else is needed.
thanks

@camilamacedo86
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 21, 2020
@camilamacedo86
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, n1r1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2020
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍

@camilamacedo86
Copy link
Member

/test pull-kubebuilder-e2e-k8s-1-17-0

@camilamacedo86
Copy link
Member

/test pull-kubebuilder-e2e-k8s-1-14-1
/test pull-kubebuilder-e2e-k8s-1-17-0

@k8s-ci-robot k8s-ci-robot merged commit 5413199 into kubernetes-sigs:master Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants