-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in deleteExternalResources comment #1495
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @n1r1! |
Hi @n1r1. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @n1r1, Tks for your collab. See that the CI is not passing. Mainly you need to assign in the CLA and run make generated to update the testdata with. See the CONTRIBUTION.md doc for a better understanding. |
Thanks @camilamacedo86 /retest |
@n1r1: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/check-cla |
I signed it |
HI @n1r1, You need to rebase this on with the master, squash the commits, and ensure that you have the SLA because if it does not pass in the CI is not possible to merge. Could you please check? |
testdata/project-v2-addon/go.mod
Outdated
@@ -9,5 +9,5 @@ require ( | |||
k8s.io/apimachinery v0.17.2 | |||
k8s.io/client-go v0.17.2 | |||
sigs.k8s.io/controller-runtime v0.5.0 | |||
sigs.k8s.io/kubebuilder-declarative-pattern v0.0.0-20200415210853-85eb326a6add | |||
sigs.k8s.io/kubebuilder-declarative-pattern v0.0.0-20200505212709-bc9d91267442 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should not be part of the pr. Could you please rebase with the master?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really thank you for your contribution 👍
Could you please rebase it with the master and then, follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.
Signed-off-by: Nir <niry@redhat.com>
@camilamacedo86 , I've signed the CLA and rebased with master. Let me know if anything else is needed. |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, n1r1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great 👍
/test pull-kubebuilder-e2e-k8s-1-17-0 |
/test pull-kubebuilder-e2e-k8s-1-14-1 |
I believe the intention was to explain idempotence, so this is just a small typo correction