fix: unable to build multigroup projects

[camilamacedo86]

closes: #1500

PS.: I do not consider this bug fix as a braking change because:

After having project scaffold and with the project layout update to multigroup support then, users are still able to use the command to re-run the edit --multigroup=true which would apply the fix.

ps.: shows that we have not too many users using the multigroup since the issue was not reported so far.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[camilamacedo86]

Hi @estroz @mengqiy @droot could you help by checking this one?

[estroz]

Instead of breaking scraffolded directory structure, something kubebuilder should do as infrequently as possible, why not add a sentence in the multi group migration docs to update the Dockerfile?

[camilamacedo86]

HI @estroz,

Thank you for your input. However, I do no thinking that we should follow-up with your suggestion.

1. Why change the api to apis when is multi-group? It has no relation with so we should not.
2. Add add a sentence in the multi-group migration docs to update the Dockerfile? it would be possible, however, may have other places that were affected and are facing issues too. Note that we did not get the issue before which shows that users are not really using it yet. And then, I do not think that request these unnecessary manually changes are a good user experience at all.

[estroz]

My 2 cents:

1. A project fundamentally changes when it transitions to support multiple groups, which is probably why the directory structure changes and should change.
2. I have not seen any related issues aside from Build is not working for multi-group #1500.

This change sounds more like a matter of preference than one that should happen for a good technical reason, since we can easily document the Dockerfile change like all other multigroup migration changes. Perhaps a better approach would be to write a phase 2 plugin to support this preference, like the one suggested in #932.

[camilamacedo86]

HI @estroz,

I am not sure if it is a matter of the preference since it is broking the project and do not let the users run the testadata gen with multigroup as suggested in the docs. When we added the multi-group option we decided to add if is multi-group the use apis/ instead of api/ or in the cleanup and changes made in this area after that, however, IHMO it shows that was a wrong decision.

So, IHMO technically in order to keep it simple and avoid other possible issues we do not need really change the name of the dir api when is multigroup since it has no relation with. Or increase the complexity of users work with and perform manual changes.

[camilamacedo86]

/hold

[camilamacedo86]

Hi @estroz,

After the discussion, the solution was changed to just provide the fix.

[camilamacedo86]

/hold cancel

[camilamacedo86]

/test pull-kubebuilder-e2e-k8s-1-14-1

[NicolasT]

Ran into this as well, suggested change is what I applied manually to resolve the issue.

[djzager]

/lgtm