Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix a literal typo and incorrect list #1548

Merged
merged 1 commit into from
Jun 4, 2020
Merged

docs: Fix a literal typo and incorrect list #1548

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions docs/book/src/reference/webhook-for-core-types.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

It is very easy to build admission webhooks for CRDs, which has been covered in
the CronJob tutorial. Given that kubebuilder doesn't support webhook scaffolding
for core types, you have to use the library from controler-runtime to handle it.
for core types, you have to use the library from controller-runtime to handle it.
There is an [example](https://github.com/kubernetes-sigs/controller-runtime/tree/master/examples/builtins)
in controller-runtime.

Expand Down Expand Up @@ -67,6 +67,7 @@ You need to ensure the path here match the path in the marker.
## Deploy

Deploying it is just like deploying a webhook server for CRD. You need to
1) provision the serving certificate 2) deploy the server
1) provision the serving certificate
2) deploy the server

You can follow the [tutorial](/cronjob-tutorial/running.md).