pkg/model/config: wrap plugin config in types #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nConfigs
is a wrapper for map[string]pluginConfig for (de)serialization purposes
and pluginConfig wraps interface{} so users do not have to see internals
of plugin config storage.
pkg/model/config: the Plugin field of a Config is now of type PluginConfigs
internal,pkg: update test cases
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, estroz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new types,
PluginConfigsandpluginConfig.PluginConfigsis a wrapper formap[string]pluginConfigfor (de)serialization purposes andpluginConfigwrapsinterface{}so users do not have to see internals of plugin config storage.Pluginfield of aConfigis now of typePluginConfigsInitial discussion: #1443.
/cc @DirectXMan12 @mengqiy @camilamacedo86