Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow plural resource names #157

Merged
merged 1 commit into from
May 14, 2018
Merged

Allow plural resource names #157

merged 1 commit into from
May 14, 2018

Conversation

pwittrock
Copy link
Contributor

Fixes #152

@pwittrock
Fixes kubernetes-sigs#152
1909c53 
Allow plural resource names.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 14, 2018
Liujingfang1
Liujingfang1 approved these changes May 14, 2018
View reviewed changes
Copy link
Contributor

@Liujingfang1 Liujingfang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pwittrock pwittrock merged commit 019fa3c into kubernetes-sigs:master May 14, 2018
luffyao pushed a commit to luffyao/kubebuilder that referenced this pull request Aug 7, 2020
@mergify
Merge pull request kubernetes-sigs#157 from alandtsang/multiversion-t…
938ffd0 
…utorial/deployment

翻译 2.4 deployment.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Liujingfang1 Liujingfang1 Liujingfang1 approved these changes

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pwittrock @Liujingfang1 @k8s-ci-robot