Revert "pkg/plugin/v3: use repo instead of directory basename as project name" #1597
Conversation
k8s-ci-robot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
|
Hi @estroz, The #1596 was merged without a second opinion. In this way, since was raised a concern on it, I raised the revert just or we check if others are ok or not with and if we should or not revert the change. @pwittrock @DirectXMan12 are you. ok with the changes made in #1596? If yes, I think we can close this one. If not. then IMO we should move with and start a new discussion. c/c @estroz @joelanford |
|
/test pull-kubebuilder-e2e-k8s-1-16-2 |
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
@camilamacedo86 Lets hold this for discussion. |
|
@camilamacedo86: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
needs-rebase
|
Closed by #1603 /close |
|
@estroz: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Reverts #1596
Important: My goal is not to move forward with. just check if others are also ok with.