-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scripts/setup_envtest_bins.sh: simplify setting envtest env vars #1615
scripts/setup_envtest_bins.sh: simplify setting envtest env vars #1615
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approved
/hold |
/lgtm |
This commit updates the setup_envtest_bins.sh script to echo the necessary export commands that set the envtest environment variables. Script users can then use this script like this: eval $(./setup_envtest_bins.sh v1.18.2 v3.4.3)
e9146d9
to
34eef3e
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: joelanford The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
echo "# To automatically configure your environment, run this script as:" | ||
echo "#" | ||
echo "# eval \$($0 $K8S_VER $ETCD_VER)'" | ||
echo "#" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
loved 👍
/lgtm |
/lgtm cancel |
Closing in favor of ; #1631 |
/close |
@camilamacedo86: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This commit updates the
setup_envtest_bins.sh
script to echo the necessary export commands that set the envtest environment variables.Script users can then use this script like this: