Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scripts/setup_envtest_bins.sh: simplify setting envtest env vars #1615

Closed
wants to merge 1 commit into from
Closed

scripts/setup_envtest_bins.sh: simplify setting envtest env vars #1615

wants to merge 1 commit into from

Conversation

joelanford
Copy link
Member

This commit updates the setup_envtest_bins.sh script to echo the necessary export commands that set the envtest environment variables.

Script users can then use this script like this:

eval $(./setup_envtest_bins.sh v1.18.2 v3.4.3)
make test

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 29, 2020
camilamacedo86
camilamacedo86 approved these changes Jul 29, 2020
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approved

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2020
@camilamacedo86
Copy link
Member

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 29, 2020
@camilamacedo86
Copy link
Member

/lgtm
Feel free to unhold when you wish 👍

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2020
@joelanford joelanford mentioned this pull request Jul 30, 2020
Merged
@joelanford
scripts/setup_envtest_bins.sh: simplify setting envtest env vars
34eef3e 
This commit updates the setup_envtest_bins.sh script to echo the
necessary export commands that set the envtest environment variables.

Script users can then use this script like this:

   eval $(./setup_envtest_bins.sh v1.18.2 v3.4.3)
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 30, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: joelanford
To complete the pull request process, please assign camilamacedo86
You can assign the PR to them by writing /assign @camilamacedo86 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2020
camilamacedo86
camilamacedo86 reviewed Jul 30, 2020
View reviewed changes
scripts/setup_envtest_bins.sh
echo "# To automatically configure your environment, run this script as:"
echo "#"
echo "# eval \$($0 $K8S_VER $ETCD_VER)'"
echo "#"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loved 👍

@camilamacedo86
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2020
@camilamacedo86
Copy link
Member

/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 1, 2020
@camilamacedo86
Copy link
Member

Closing in favor of ; #1631
we will remove the script.

@camilamacedo86
Copy link
Member

/close

@k8s-ci-robot
Copy link
Contributor

@camilamacedo86: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@mengqiy mengqiy Awaiting requested review from mengqiy

Assignees

@camilamacedo86 camilamacedo86

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joelanford @camilamacedo86 @k8s-ci-robot