Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: organize templates in the same structure that they are scaffolded #1623

Merged
merged 1 commit into from
Aug 15, 2020

Conversation

camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented Jul 30, 2020

Description
Organize templates aligned with the same structure that they are scaffolded

.
├── config
│   ├── api
│   │   ├── group.go
│   │   ├── types.go
│   │   └── webhook.go
│   ├── certmanager
│   │   ├── certificate.go
│   │   ├── kustomize.go
│   │   └── kustomizeconfig.go
│   ├── controller
│   │   ├── controller.go
│   │   └── controller_suitetest.go
│   ├── crd
│   │   ├── enablecainjection_patch.go
│   │   ├── enablewebhook_patch.go
│   │   ├── kustomization.go
│   │   └── kustomizeconfig.go
│   ├── hack
│   │   └── boilerplate.go
│   ├── kdefault
│   │   ├── auth_proxy_patch.go
│   │   ├── enablecainection_patch.go
│   │   ├── kustomize.go
│   │   └── webhook_manager_patch.go
│   ├── manager
│   │   ├── config.go
│   │   └── kustomization.go
│   ├── prometheus
│   │   ├── kustomize.go
│   │   └── monitor.go
│   ├── rbac
│   │   ├── auth_proxy_role.go
│   │   ├── auth_proxy_rolebinding.go
│   │   ├── auth_proxy_service.go
│   │   ├── client_cluster_role.go
│   │   ├── crd_editor_rbac.go
│   │   ├── crd_viewer_rbac.go
│   │   ├── leader_election_role.go
│   │   ├── leader_election_rolebinding.go
│   │   ├── manager_role_binding.go
│   │   └── rbac.go
│   ├── samples
│   │   └── crd_sample.go
│   └── webhook
│       ├── kustomization.go
│       ├── kustomizeconfig.go
│       └── service.go
├── dockerfile.go
├── dockerignorefile.go
├── gitignore.go
├── gomod.go
├── main.go
└── makefile.go

Motivation
Keep it more intuitive for new contributors and easy to mantain.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 30, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2020
@camilamacedo86
Copy link
Member Author

/test pull-kubebuilder-e2e-k8s-1-16-2

Copy link
Contributor

@gabbifish gabbifish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tiny nits about grouping imports, otherwise this looks great!

pkg/plugin/v3/scaffolds/api.go Outdated Show resolved Hide resolved
pkg/plugin/v3/scaffolds/init.go Outdated Show resolved Hide resolved
pkg/plugin/v3/scaffolds/webhook.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 31, 2020
@pwittrock
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 14, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, pwittrock

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [camilamacedo86,pwittrock]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@camilamacedo86
Copy link
Member Author

/test pull-kubebuilder-e2e-k8s-1-14-1

@camilamacedo86
Copy link
Member Author

/test pull-kubebuilder-e2e-k8s-1-15-3

@camilamacedo86 camilamacedo86 changed the title cleanup: organize templates in the same structure that the are scaffolded cleanup: organize templates in the same structure that they are scaffolded Aug 15, 2020
@k8s-ci-robot k8s-ci-robot merged commit c47c1bc into kubernetes-sigs:master Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants