Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix old link to envtest docs that should have been removed #1624

Merged
merged 1 commit into from
Aug 14, 2020

Conversation

gabbifish
Copy link
Contributor

@gabbifish gabbifish commented Aug 1, 2020

This PR fixes #1621, which was caused by an old sidebar link that should have been deleted as part of moving the integration test example under the CronJob example section.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 1, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @gabbifish. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 1, 2020
@camilamacedo86
Copy link
Member

camilamacedo86 commented Aug 4, 2020

Hi @gabbifish,

Really nice, following some nits.

Screen Shot 2020-08-04 at 09 18 30

The name of the section is: Configuring envtest for integration tests. So, we need to update that.

  • Also, in the submenu after this change:

Screen Shot 2020-08-04 at 09 22 29

IMO it needs to be changed to be like the others. Maybe Configuring EnvTest. WDYT?

@gabbifish
Copy link
Contributor Author

Ooh, great catches! I addressed both bullet points--let me know what you think!

@camilamacedo86
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 10, 2020
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approved

👍 it shows great for me

@camilamacedo86
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, gabbifish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2020
@camilamacedo86
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 13, 2020
@camilamacedo86
Copy link
Member

Hi @gabbifish,

Could you rebase with the master and squash the commits for we are able to merge this one?

/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 14, 2020
@gabbifish
Copy link
Contributor Author

@camilamacedo86 rebased on master and squashed!

@camilamacedo86
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 14, 2020
@k8s-ci-robot k8s-ci-robot merged commit d4c75d5 into kubernetes-sigs:master Aug 14, 2020
gabbifish pushed a commit to gabbifish/kubebuilder that referenced this pull request Aug 26, 2020
Fix old link to envtest docs that should have been removed
gabbifish pushed a commit to gabbifish/kubebuilder that referenced this pull request Aug 31, 2020
Fix old link to envtest docs that should have been removed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: Controller-test doc page is render blank
3 participants