-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix old link to envtest docs that should have been removed #1624
Conversation
Hi @gabbifish. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @gabbifish, Really nice, following some nits.
The name of the section is:
IMO it needs to be changed to be like the others. Maybe |
Ooh, great catches! I addressed both bullet points--let me know what you think! |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approved
👍 it shows great for me
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, gabbifish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Hi @gabbifish, Could you rebase with the master and squash the commits for we are able to merge this one? /lgtm cancel |
@camilamacedo86 rebased on master and squashed! |
/lgtm |
Fix old link to envtest docs that should have been removed
Fix old link to envtest docs that should have been removed
This PR fixes #1621, which was caused by an old sidebar link that should have been deleted as part of moving the integration test example under the CronJob example section.