-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update reference with name of page #1662
doc: update reference with name of page #1662
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @rytswd! |
Hi @rytswd. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I signed the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
Really tks for the contribution 🥇
/lgtm
/test pull-kubebuilder-e2e-k8s-1-15-3 |
docs/book/src/cronjob-tutorial/testdata/project/api/v1/cronjob_webhook.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please squash the commits for we are able to get it merged?
Update docs/book/src/cronjob-tutorial/testdata/project/api/v1/cronjob_webhook.go Co-authored-by: Gabbi Fisher <gabbifisher@gmail.com>
b87ae55
to
1ccd3bc
Compare
Should be squashed now |
/retest |
/test pull-kubebuilder-e2e-k8s-1-17-0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Now, that it is with the @gabbifish suggestion 👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, rytswd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@rytswd: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test pull-kubebuilder-e2e-k8s-1-17-0 |
Just to understand, are these CI failures just some transient failure with kind? |
Hi @rytswd, flakes on the CI. When it happens we need to add the comment to re-run the specific test. |
/lgtm |
Change Description
Change Motivation
Better readability
As this is a minor change, there is no associated issue (as far as I could see).