-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️(v3+ only) feat: update cert-manager crd to v1.0 in kubebuilder v3 #1667
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @MartinForReal! |
Hi @MartinForReal. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/check-cla |
/assign @droot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really thank you for your contribution. 🥇 Just a few nits:
- Note that The pkg/plugin/v2 ought to receive only fix bugs and cannot have breaking changes. All improvements and etc needs to be addressed only in pkg/plugin/v3. Could you please update it?
- Also, note that it is not passing in the testdata. After change the templates we need to run
make generate
it will re-generate the testdata - Could you please add (v3 only) in the title as well?
PS.: the commits need to be squashed.
I've changed the commit accordingly. FYI @camilamacedo86 Thanks! |
Hi @MartinForReal, It shows great. See that it is not passing in the check to verify if the testdata/ samples are updated. See: https://travis-ci.org/github/kubernetes-sigs/kubebuilder/jobs/725451668#L1003-L1038 To update these samples we run
|
/assign @camilamacedo86 |
Hi @camilamacedo86, Thanks for your instructions~ |
testdata/project-v2-multigroup/config/certmanager/certificate.yaml
Outdated
Show resolved
Hide resolved
/ok-to-test |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: MartinForReal The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It shows ok now. Great work. Also, I checked in https://cert-manager.io/docs/installation/upgrading/. Could you please add this link in the first comment as well just for we keep easy the info if someone needs to check that after? Also, note that it is not passing in the e2e tests which means that is not working well https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_kubebuilder/1667/pull-kubebuilder-e2e-k8s-1-14-1/1303636850719592448#1:build-log.txt%3A1017. See that the v1 version required CRD v1 as well.
So, it is blocked by #1644. c/c @estroz |
Signed-off-by: MartinForReal <fanshangxiang@gmail.com>
@MartinForReal: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@MartinForReal: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
const certmanagerVersion = "v1.0.1" | ||
const certmanagerURL = "https://github.com/jetstack/cert-manager/releases/download/%s/cert-manager-legacy.yaml" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should not be added here. See;
const certmanagerVersion = "v0.11.0" |
We need to update it in the utils. I'd recommend that the func InstallCertManager()
would check the project config and would apply the cert-manager accordingly. if project.isV2 then, apply the current version used, otherwise apply the upper version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -31,6 +31,9 @@ import ( | |||
"sigs.k8s.io/kubebuilder/test/e2e/utils" | |||
) | |||
|
|||
const certmanagerVersion = "v1.0.1" | |||
const certmanagerURL = "https://github.com/jetstack/cert-manager/releases/download/%s/cert-manager-legacy.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MartinForReal you'll be able to customize which set of manifests to use (current vs legacy) with kubectl version once #1644 is merged.
const prometheusOperatorVersion = "0.33" | ||
const certmanagerURL = "https://github.com/jetstack/cert-manager/releases/download/%s/cert-manager.yaml" | ||
const prometheusOperatorURL = "https://raw.githubusercontent.com/coreos/prometheus-operator/release-%s/bundle.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to keep this one and then, in the e2e tests for the v3-alpha we should use the upper version and for the v2+ we should keep using this one.
Signed-off-by: MartinForReal fanshangxiang@gmail.cn
Fixed: #1666
Migrate cert-manager related CR to v1