⚠️(v3+ only) feat: update cert-manager crd to v1.0 in kubebuilder v3

[MartinForReal]

Signed-off-by: MartinForReal fanshangxiang@gmail.cn
Fixed: #1666

Migrate cert-manager related CR to v1

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @MartinForReal!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @MartinForReal. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[MartinForReal]

/check-cla

[MartinForReal]

/assign @droot

[camilamacedo86]

Really thank you for your contribution. 🥇 Just a few nits:

• Note that The pkg/plugin/v2 ought to receive only fix bugs and cannot have breaking changes. All improvements and etc needs to be addressed only in pkg/plugin/v3. Could you please update it?
• Also, note that it is not passing in the testdata. After change the templates we need to run make generate it will re-generate the testdata
• Could you please add (v3 only) in the title as well?

PS.: the commits need to be squashed.

[MartinForReal]

I've changed the commit accordingly. FYI @camilamacedo86 Thanks!

[camilamacedo86]

Hi @MartinForReal,

It shows great. See that it is not passing in the check to verify if the testdata/ samples are updated. See: https://travis-ci.org/github/kubernetes-sigs/kubebuilder/jobs/725451668#L1003-L1038

To update these samples we run make generate. Any change on the templates requires we run this command to do the pr. Could you please check it? Also, could you please add on the title (v3+ only)? And we need to start to use :

All code PR must be labeled with 🐛 (patch fixes), ✨ (backwards-compatible features), or ⚠️ (breaking changes)
For a quick PR template suggesting the right information, use one of these PR templates:
Breaking Changes/Features
Backwards-Compatible Features
Bug fixes
Documentation Changes
Test/Build/Other Changes

[MartinForReal]

/assign @camilamacedo86

[MartinForReal]

Hi @camilamacedo86,

Thanks for your instructions~

[camilamacedo86]

/ok-to-test

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MartinForReal
To complete the pull request process, please assign camilamacedo86
You can assign the PR to them by writing /assign @camilamacedo86 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[camilamacedo86]

It shows ok now. Great work. Also, I checked in https://cert-manager.io/docs/installation/upgrading/. Could you please add this link in the first comment as well just for we keep easy the info if someone needs to check that after?

Also, note that it is not passing in the e2e tests which means that is not working well https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_kubebuilder/1667/pull-kubebuilder-e2e-k8s-1-14-1/1303636850719592448#1:build-log.txt%3A1017. See that the v1 version required CRD v1 as well.

cert-manager now uses apiextensions.k8s.io/v1 to install CRDs inside Kubernetes

So, it is blocked by #1644.

c/c @estroz

[k8s-ci-robot]

@MartinForReal: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-kubebuilder-e2e-k8s-1-16-2	98dd786	link	/test pull-kubebuilder-e2e-k8s-1-16-2
pull-kubebuilder-e2e-k8s-1-15-3	98dd786	link	/test pull-kubebuilder-e2e-k8s-1-15-3
pull-kubebuilder-e2e-k8s-1-14-1	98dd786	link	/test pull-kubebuilder-e2e-k8s-1-14-1
pull-kubebuilder-e2e-k8s-1-17-0	98dd786	link	/test pull-kubebuilder-e2e-k8s-1-17-0

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

@MartinForReal: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[camilamacedo86]

it should not be added here. See;

kubebuilder/test/e2e/utils/test_context.go

Line 30 in 9406d91

const certmanagerVersion = "v0.11.0"

We need to update it in the utils. I'd recommend that the func InstallCertManager() would check the project config and would apply the cert-manager accordingly. if project.isV2 then, apply the current version used, otherwise apply the upper version.

[camilamacedo86]

@MartinForReal ^

[estroz]

@MartinForReal you'll be able to customize which set of manifests to use (current vs legacy) with kubectl version once #1644 is merged.

[camilamacedo86]

We need to keep this one and then, in the e2e tests for the v3-alpha we should use the upper version and for the v2+ we should keep using this one.