Fix 1680: Usage of nonexistent namespace in cronjob example tests #1681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
size/XS
k8s-ci-robot
added
the
cncf-cla: yes
camilamacedo86
approved these changes
Sep 15, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, gabbifish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
camilamacedo86
approved these changes
Sep 16, 2020
There was a problem hiding this comment.
I tested it with the PR to update the doc samples: https://github.com/kubernetes-sigs/kubebuilder/pull/1681/files
All worked see:
camilamacedo@Camilas-MacBook-Pro ~/go/src/sigs.k8s.io/kubebuilder/docs/book/src/cronjob-tutorial/testdata/project (update-docs-tes-fix) $ make test
/Users/camilamacedo/go/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."
go fmt ./...
go vet ./...
/Users/camilamacedo/go/bin/controller-gen "crd:trivialVersions=true" rbac:roleName=manager-role webhook paths="./..." output:crd:artifacts:config=config/crd/bases
mkdir -p /Users/camilamacedo/go/src/sigs.k8s.io/kubebuilder/docs/book/src/cronjob-tutorial/testdata/project/testbin
test -f /Users/camilamacedo/go/src/sigs.k8s.io/kubebuilder/docs/book/src/cronjob-tutorial/testdata/project/testbin/setup-envtest.sh || curl -sSLo /Users/camilamacedo/go/src/sigs.k8s.io/kubebuilder/docs/book/src/cronjob-tutorial/testdata/project/testbin/setup-envtest.sh https://raw.githubusercontent.com/kubernetes-sigs/controller-runtime/master/hack/setup-envtest.sh
source /Users/camilamacedo/go/src/sigs.k8s.io/kubebuilder/docs/book/src/cronjob-tutorial/testdata/project/testbin/setup-envtest.sh; fetch_envtest_tools /Users/camilamacedo/go/src/sigs.k8s.io/kubebuilder/docs/book/src/cronjob-tutorial/testdata/project/testbin; setup_envtest_env /Users/camilamacedo/go/src/sigs.k8s.io/kubebuilder/docs/book/src/cronjob-tutorial/testdata/project/testbin; go test ./... -coverprofile cover.out
fetching envtest tools@1.16.4 (into '/Users/camilamacedo/go/src/sigs.k8s.io/kubebuilder/docs/book/src/cronjob-tutorial/testdata/project/testbin')
x bin/
x bin/etcd
x bin/kubectl
x bin/kube-apiserver
setting up env vars
? tutorial.kubebuilder.io/project [no test files]
? tutorial.kubebuilder.io/project/api/v1 [no test files]
ok tutorial.kubebuilder.io/project/controllers 16.571s coverage: 40.3% of statements
/lgtm
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #1680. The cause of the bug was usage of a namespace that did not exist yet; in the test, we now use the
defaultnamespace that is guaranteed to exist without extra boilerplate logic. We also useprinter.NewlineReporter{}consistent with this change in other kubebuilder code.