✨ replace deprecated function LoggerTo() from zap package (only v3+) #1692

antcs · 2020-09-23T19:07:37Z

Deprecated: func LoggerTo(destWriter io.Writer, development bool) logr.Logger
Will use the new function instead: https://github.com/kubernetes-sigs/controller-runtime/blob/master/pkg/log/zap/zap.go#L42

k8s-ci-robot · 2020-09-23T19:07:40Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2020-09-23T19:07:45Z

Welcome @antcs!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2020-09-23T19:07:46Z

Hi @antcs. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

antcs · 2020-09-23T19:13:12Z

I signed it

camilamacedo86 · 2020-09-24T11:06:01Z

pkg/plugin/v2/scaffolds/internal/templates/controller/controller_suitetest.go

@@ -144,7 +144,7 @@ func TestAPIs(t *testing.T) {
 }

 var _ = BeforeSuite(func(done Done) {
-	logf.SetLogger(zap.LoggerTo(GinkgoWriter, true))
+	logf.SetLogger(zap.New(zap.WriteTo(GinkgoWriter), zap.UseDevMode(true)))


I am afraid that we cannot change the v2. Only the v3 in this case.

camilamacedo86

Really tks for your contribution 🥇. It is great. Following some needs:

Do the change only for v3
Assign yourself to CLA. See: ✨ replace deprecated function LoggerTo() from zap package (only v3+) #1692 (comment)
The title should have the mojo :sparkles: . See: https://github.com/kubernetes-sigs/kubebuilder/blob/master/CONTRIBUTING.md#pr-process. Also, could you add (only v3+) as well?
Changes in the scaffolds requires we update the testdata dir. It is done by running the makefile target make generate.

antcs · 2020-09-24T15:39:12Z

@camilamacedo86 Hopefully all requests are satisfied.

gabbifish · 2020-09-25T07:01:13Z

/ok-to-test

camilamacedo86 · 2020-09-25T09:49:53Z

/test pull-kubebuilder-e2e-k8s-1-17-0
/test pull-kubebuilder-e2e-k8s-1-15-3

camilamacedo86

/approve

Great work 👍

gabbifish · 2020-09-25T17:51:29Z

/approve

k8s-ci-robot · 2020-09-25T17:51:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: antcs, camilamacedo86, gabbifish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

antcs · 2020-09-28T17:00:38Z

@gabbifish @camilamacedo86 The lgtm label is missing here. Who will add it to the pull request? I would assume not me as I opened the pr.

gabbifish · 2020-10-01T06:29:07Z

/lgtm

Thank you for your patience here! :)

gabbifish · 2020-10-01T07:15:27Z

/test pull-kubebuilder-e2e-k8s-1-15-3

gabbifish · 2020-10-01T07:35:33Z

/test pull-kubebuilder-e2e-k8s-1-16-2

camilamacedo86 · 2020-10-01T14:00:30Z

/test pull-kubebuilder-e2e-k8s-1-16-2

DirectXMan12 · 2020-10-02T00:12:37Z

hmmm... somehow this missed a generated file: https://travis-ci.org/github/kubernetes-sigs/kubebuilder/jobs/732111307.

PR kubernetes-sigs#1692 updated the v3 scaffolding, but missed a generated file that was somehow not caught by CI until now. This fixes that.

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 23, 2020

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 23, 2020

k8s-ci-robot requested review from camilamacedo86 and joelanford September 23, 2020 19:07

camilamacedo86 reviewed Sep 24, 2020

View reviewed changes

camilamacedo86 requested changes Sep 24, 2020

View reviewed changes

antcs changed the title ~~replace deprecated function LoggerTo() from zap package~~ ✨ replace deprecated function LoggerTo() from zap package Sep 24, 2020

antcs force-pushed the replace-deprecated-LoggerTo branch from 8bb80db to 325c864 Compare September 24, 2020 15:34

antcs changed the title ~~✨ replace deprecated function LoggerTo() from zap package~~ ✨ replace deprecated function LoggerTo() from zap package (only v3+) Sep 24, 2020

✨ replace deprecated function LoggerTo() from zap package (only v3+)

4eee159

antcs force-pushed the replace-deprecated-LoggerTo branch from 325c864 to 4eee159 Compare September 24, 2020 15:42

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 25, 2020

camilamacedo86 approved these changes Sep 25, 2020

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2020

k8s-ci-robot assigned gabbifish Oct 1, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 1, 2020

k8s-ci-robot merged commit 5c133da into kubernetes-sigs:master Oct 1, 2020

antcs deleted the replace-deprecated-LoggerTo branch October 1, 2020 14:50

camilamacedo86 mentioned this pull request Feb 18, 2021

New Release - proposing 3.0.0 stable #2029

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ replace deprecated function LoggerTo() from zap package (only v3+) #1692

✨ replace deprecated function LoggerTo() from zap package (only v3+) #1692

antcs commented Sep 23, 2020

k8s-ci-robot commented Sep 23, 2020

k8s-ci-robot commented Sep 23, 2020

k8s-ci-robot commented Sep 23, 2020

antcs commented Sep 23, 2020

camilamacedo86 Sep 24, 2020 •

edited

Loading

camilamacedo86 left a comment

antcs commented Sep 24, 2020

gabbifish commented Sep 25, 2020

camilamacedo86 commented Sep 25, 2020

camilamacedo86 left a comment

gabbifish commented Sep 25, 2020

k8s-ci-robot commented Sep 25, 2020

antcs commented Sep 28, 2020

gabbifish commented Oct 1, 2020

gabbifish commented Oct 1, 2020 •

edited

Loading

gabbifish commented Oct 1, 2020

camilamacedo86 commented Oct 1, 2020

DirectXMan12 commented Oct 2, 2020

✨ replace deprecated function LoggerTo() from zap package (only v3+) #1692

✨ replace deprecated function LoggerTo() from zap package (only v3+) #1692

Conversation

antcs commented Sep 23, 2020

k8s-ci-robot commented Sep 23, 2020

k8s-ci-robot commented Sep 23, 2020

k8s-ci-robot commented Sep 23, 2020

antcs commented Sep 23, 2020

camilamacedo86 Sep 24, 2020 • edited Loading

Choose a reason for hiding this comment

camilamacedo86 left a comment

Choose a reason for hiding this comment

antcs commented Sep 24, 2020

gabbifish commented Sep 25, 2020

camilamacedo86 commented Sep 25, 2020

camilamacedo86 left a comment

Choose a reason for hiding this comment

gabbifish commented Sep 25, 2020

k8s-ci-robot commented Sep 25, 2020

antcs commented Sep 28, 2020

gabbifish commented Oct 1, 2020

gabbifish commented Oct 1, 2020 • edited Loading

gabbifish commented Oct 1, 2020

camilamacedo86 commented Oct 1, 2020

DirectXMan12 commented Oct 2, 2020

camilamacedo86 Sep 24, 2020 •

edited

Loading

gabbifish commented Oct 1, 2020 •

edited

Loading