-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ store all config info (go/v3-alpha) #1696
✨ store all config info (go/v3-alpha) #1696
Conversation
3bc4e25
to
bf43bed
Compare
ca5dbeb
to
14e00cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some minor nits and a suggestion for an extra validity check, otherwise this looks great!! Your tests are so comprehensive 😍
14e00cc
to
3240f39
Compare
3240f39
to
40cf2ea
Compare
40cf2ea
to
151c131
Compare
/hold cancel @gabbifish fell free to re-check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some tiny nits for gkv->gvk
--once those are done, I'll approve! :D
/hold we are trying to reach a consensus to move forward here. |
3390cfe
to
a6bbd90
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be a mismatch of data between config.ResourceData
, resource.Resource
, and resource.Options
. The latter two are constructed by the plugin layer, which passes a resource.Resource
to the scaffold layer to be used and updated. Therefore all of these structs should have the same field subset relating to a resource as an element of config.ResourceData.Resources
.
a6bbd90
to
fecb8a3
Compare
b213920
to
c48b189
Compare
08aa09c
to
278b3a9
Compare
278b3a9
to
951784f
Compare
/test pull-kubebuilder-e2e-k8s-1-18-0 |
/hold cancel It has all suggested attrs in the format agreed as it is addressing all suggested made. |
Close in favor of #1869 |
Description
Store in the PROJECT file:
Refractories/Cleanups suggested:
doResource
withdoAPI
only for v3 internal code.PS.: Note the plugin v2 internal code was changed/updated where only it would be mandatory in order to move forward with the changes. The idea is we ensure and not risk introduces breaking changes or bugs into it since we are closer to deprecated it.
Regards the tests:
Example
Following an example with the edge cases and that cover nearly all scenarios.
Motivation
Close: #1826
/hold
If we do not able o ve forward with #1869 instead of this one. Then, here would be required to do a few changes :