-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update flect from v0.2.1 to v0.2.2 #1698
Conversation
Welcome @grdryn! |
Hi @grdryn. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This module is used for pluralization of kinds here in kubebuilder. There's a fix in v0.2.2 for the pluralization of a kind name in an operator that I'm working with, where it's currently getting the incorrect pluralization.
6596132
to
8b27790
Compare
/assign @estroz |
Hi @grdryn! Thank you for submitting this! Before I review this, I'd love more context about the issue--mind pointing me to a GitHub issue with your bug, or demonstrating an example of what this dependency upgrade fixes? After that I can promptly review your PR :) |
@gabbifish Hi, thanks for taking a look. I don't have a GitHub repo yet where the issue can be seen (it's just an operator I'm working with in my spare time so far, will have a repo soon, hopefully 🙂 ), but here's the change from flect that fixes it: gobuffalo/flect#46 Essentially, without this update, if you run the following (kind is the important param):
Then in some of the generated code, and in some filenames, kubebuilder will put the pluralized version of the kind name, and it uses the flect library to decide what that should be. Flect has a list of general rules, and then a lot of exceptional cases because, well, English has a lot of exceptions. In this particular case, flect was using the general rule "if the singular ends with So while that might be the correct way to pluralize words ending with |
@grdryn Thank you for your thorough explanation! This totally makes sense (and wow at the level of detail flect goes into!) Running tests on this and if all tests pass (they should) I'll approve :) /ok-to-test |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: estroz, grdryn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Thanks a lot @gabbifish and @estroz! 🙌 |
This module is used for pluralization of kinds here in
kubebuilder. There's a fix in v0.2.2 for the pluralization of a kind
name in an operator that I'm working with, where it's currently
getting the incorrect pluralization.