Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix the webhook creation for defaulting webhooks #1718

Merged
merged 1 commit into from
Oct 26, 2020

Conversation

prafull01
Copy link
Contributor

Description:
Remove the import k8s.io/apimachinery/pkg/runtime in webhook scaffolding for the defaulting webhooks.

Motivation:
Webhook defaulting scaffolding imports the k8s.io/apimachinery/pkg/runtime which it doesn't use in the code and hence the building of project throws an error.

prafull@EMPID18004:~/go/src/github.com/prafull01/kubebuilder/proj$ ../bin/kubebuilder create webhook --group praf --version v1beta1 --kind Laker --defaulting
Writing scaffold for you to edit...
api/v1beta1/laker_webhook.go
prafull@EMPID18004:~/go/src/github.com/prafull01/kubebuilder/proj$ make 
/home/prafull/go/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."
go fmt ./...
go vet ./...
# sigs.k8s.io/kubebuilder/api/v1beta1
api/v1beta1/laker_webhook.go:20:2: imported and not used: "k8s.io/apimachinery/pkg/runtime"
make: *** [Makefile:51: vet] Error 2```

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 9, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @prafull01. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 9, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 9, 2020
@prafull01
Copy link
Contributor Author

@camilamacedo86 Should we add the tests of --defaulting and --programmatic-validation separately in the generate_testdata.sh. WDYT?

@camilamacedo86
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 9, 2020
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 9, 2020
@prafull01
Copy link
Contributor Author

/retest

@prafull01
Copy link
Contributor Author

/test pull-kubebuilder-e2e-k8s-1-15-3

1 similar comment
@prafull01
Copy link
Contributor Author

/test pull-kubebuilder-e2e-k8s-1-15-3

Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @prafull01,

could you please just fix the nit in the generate_testdata.sh?
Otherwise, it shows great.

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2020
@prafull01
Copy link
Contributor Author

/test pull-kubebuilder-e2e-k8s-1-16-2

@prafull01
Copy link
Contributor Author

/retest

Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bug was reproduced locally with the following steps:

kubebuilder init
kubebuilder create api --group ship --version v1beta1 --kind Frigate
kubebuilder create webhook --group ship --version v1beta1 --kind Frigate --defaulting

See the import not used in api/v1beta1/frigate_webhook.go:

Screen Shot 2020-10-26 at 07 55 16

And then, by using this PR we can check that it is solved:

Screen Shot 2020-10-26 at 07 57 52

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 26, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, prafull01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants