-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix the webhook creation for defaulting webhooks #1718
Conversation
Hi @prafull01. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@camilamacedo86 Should we add the tests of --defaulting and --programmatic-validation separately in the |
/ok-to-test |
/retest |
/test pull-kubebuilder-e2e-k8s-1-15-3 |
1 similar comment
/test pull-kubebuilder-e2e-k8s-1-15-3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @prafull01,
could you please just fix the nit in the generate_testdata.sh?
Otherwise, it shows great.
/approve
10c43d0
to
bad0907
Compare
/test pull-kubebuilder-e2e-k8s-1-16-2 |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bug was reproduced locally with the following steps:
kubebuilder init
kubebuilder create api --group ship --version v1beta1 --kind Frigate
kubebuilder create webhook --group ship --version v1beta1 --kind Frigate --defaulting
See the import not used in api/v1beta1/frigate_webhook.go:
And then, by using this PR we can check that it is solved:
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, prafull01 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description:
Remove the
import k8s.io/apimachinery/pkg/runtime
in webhook scaffolding for the defaulting webhooks.Motivation:
Webhook defaulting scaffolding imports the
k8s.io/apimachinery/pkg/runtime
which it doesn't use in the code and hence the building of project throws an error.