✨ remove v1 version and only shows --plugins flag when the project version is != V2 #1763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
camilamacedo86
force-pushed
the
v1-cleanup
branch
from
0a24a2e
to
69d2259
Compare
camilamacedo86
changed the title
camilamacedo86
changed the title
camilamacedo86
changed the title
camilamacedo86
changed the title
estroz
reviewed
Nov 2, 2020
estroz
reviewed
Nov 2, 2020
estroz
reviewed
Nov 2, 2020
camilamacedo86
force-pushed
the
v1-cleanup
branch
from
69d2259
to
e9a458e
Compare
estroz
reviewed
Nov 3, 2020
| @@ -46,7 +46,7 @@ func (c *cli) newInitCmd() *cobra.Command { | |||
| cmd.Flags().String(projectVersionFlag, c.defaultProjectVersion, | |||
| fmt.Sprintf("project version, possible values: (%s)", strings.Join(c.getAvailableProjectVersions(), ", "))) | |||
| // The --plugins flag can only be called to init projects v2+. | |||
| if c.projectVersion != config.Version1 { | |||
| if c.projectVersion != config.Version2 { | |||
There was a problem hiding this comment.
I think this is ok, since project version 2 isn't the default anymore and doesn't have the concept of plugins in its spec.
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, estroz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test pull-kubebuilder-e2e-k8s-1-17-0 |
|
So basically |
|
@Adirio yes. Project version 2 uses a plugin internally; from a user's perspective there is no plugin being used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation
#1636
Co-author @estroz