Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨Suggestions for create and alpha commands #1775

Merged
merged 1 commit into from
Nov 6, 2020
Merged

✨Suggestions for create and alpha commands #1775

merged 1 commit into from
Nov 6, 2020

Conversation

Adirio
Copy link
Contributor

@Adirio Adirio commented Nov 3, 2020 •
edited
Loading

Description

Added suggestions for some commands so that when the CLI user writes a similar term it gets useful help information telling him the correct subcommand name

  • create: new
  • alpha: experimental

@Adirio
Added suggestions for some commands so that when the CLI user writes …
7352cfe 
…a similar term it gets useful help information telling him the correct subcommand name

- `create`: `new`
- `alpha`: `experimental`

Signed-off-by: Adrian Orive <adrian.orive.oneca@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 3, 2020
@Adirio Adirio changed the title ✨Suggestions for some commands ✨Suggestions for create and alpha commands Nov 3, 2020
camilamacedo86
camilamacedo86 approved these changes Nov 6, 2020
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Adirio, camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2020
@camilamacedo86
Copy link
Member

Too small for wait for 2 reviews. Let's get it merged.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2020
@k8s-ci-robot k8s-ci-robot merged commit b249df4 into kubernetes-sigs:master Nov 6, 2020
@Adirio Adirio deleted the command-suggestions branch November 6, 2020 17:40
@camilamacedo86 camilamacedo86 mentioned this pull request Feb 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@mengqiy mengqiy Awaiting requested review from mengqiy

Assignees

@camilamacedo86 camilamacedo86

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Adirio @k8s-ci-robot @camilamacedo86