-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 cleanup: remove v1 comment #1786
Conversation
/lgtm |
The error from Travis is due to a leak in #1760 which missed one of the files in |
39f4e3a
to
be75332
Compare
@@ -47,30 +47,28 @@ func TestAPIs(t *testing.T) { | |||
[]Reporter{printer.NewlineReporter{}}) | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See: #1789
/hold
until the above one gets merged it rebased.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ping me for a lgtm
label after a rebase
be75332
to
a77666d
Compare
/hold cancel rebased wth master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Adirio, camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Remove the comment over v1, since no longer exists v1 code in the project
Motivation
Closes: #1781