Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix minor issues in finding boilerplate and sample #18

Merged
merged 2 commits into from
Mar 21, 2018
Merged

Fix minor issues in finding boilerplate and sample #18

merged 2 commits into from
Mar 21, 2018

Conversation

pwittrock
Copy link
Contributor

  • Always look for boilerplate in hack/boilerplate.go.txt
  • Set the iargs variable in the sample controller

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 21, 2018
@pwittrock pwittrock merged commit 4b02bf2 into kubernetes-sigs:master Mar 21, 2018
luffyao pushed a commit to luffyao/kubebuilder that referenced this pull request Jul 25, 2020
@3ks
translate readme (kubernetes-sigs#18)
c39c50f 
docs/book add the README.md
luffyao pushed a commit to luffyao/kubebuilder that referenced this pull request Aug 10, 2020
@3ks
translate readme (kubernetes-sigs#18)
407e578 
docs/book add the README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pwittrock @k8s-ci-robot