Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠ (go/v3-alpha) deps: bump controller-runtime to v0.7.0-alpha.6 #1804

Merged
merged 1 commit into from
Nov 9, 2020
Merged

⚠ (go/v3-alpha) deps: bump controller-runtime to v0.7.0-alpha.6 #1804

merged 1 commit into from
Nov 9, 2020

Conversation

estroz
Copy link
Contributor

@estroz estroz commented Nov 9, 2020

This PR bumps the go/v3-alpha plugin to controller-runtime v0.7.0

  • deps: bump go/v3-alpha to controller-runtime v0.7.0-alpha.6 and kubebuilder-declarative-pattern to 1cbf859290cab81ae8e73fc5caebe792280175d1
  • pkg/plugin/v3: make changes to controller and test suite related to controller-runtime API changes

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 9, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2020
@estroz
Copy link
Contributor Author

estroz commented Nov 9, 2020

/cc @camilamacedo86 @christopherhein
/ping @varshaprasad96

This was referenced Nov 9, 2020
Merged
Closed
@camilamacedo86
Copy link
Member

/test pull-kubebuilder-test

@estroz
deps: bump go/v3-alpha to controller-runtime v0.7.0-alpha.6
522fbf8 
pkg/plugin/v3: make changes to controller and test suite related to
controller-runtime API changes
camilamacedo86
camilamacedo86 approved these changes Nov 9, 2020
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

👍

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, estroz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [camilamacedo86,estroz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

christopherhein
christopherhein reviewed Nov 9, 2020
View reviewed changes
pkg/plugin/v3/api.go
@@ -40,7 +40,7 @@ import (
// KbDeclarativePatternVersion is the sigs.k8s.io/kubebuilder-declarative-pattern version
// (used only to gen api with --pattern=addon)
// TODO: remove this when a better solution for using addons is implemented.
const KbDeclarativePatternVersion = "v0.0.0-20200522144838-848d48e5b073"
const KbDeclarativePatternVersion = "1cbf859290cab81ae8e73fc5caebe792280175d1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

barring that this is just for the alpha setup, does KB declarative patterns plan to institute release/versioning with semver?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great question. @camilamacedo86 do you know?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think so. However, I raised an issue there to request it for the authors. See: kubernetes-sigs/kubebuilder-declarative-pattern#130 Let's see.

@christopherhein
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 81a6cb3 into kubernetes-sigs:master Nov 9, 2020
@estroz estroz deleted the deps/c-r-v0.7.0 branch November 9, 2020 23:24
@camilamacedo86 camilamacedo86 mentioned this pull request Feb 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherhein christopherhein christopherhein left review comments

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@Adirio Adirio Awaiting requested review from Adirio

@pwittrock pwittrock Awaiting requested review from pwittrock

Assignees

@christopherhein christopherhein

@camilamacedo86 camilamacedo86

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@estroz @camilamacedo86 @k8s-ci-robot @christopherhein