Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ (go/v3-alpha) *: Replace 'docker build . -t ${IMG}' with '-t ${IMG} .' #1817

Merged
merged 1 commit into from
Nov 16, 2020
Merged

✨ (go/v3-alpha) *: Replace 'docker build . -t ${IMG}' with '-t ${IMG} .' #1817

merged 1 commit into from
Nov 16, 2020
+4 −4

Commits on Nov 16, 2020

  1. ✨ *: Replace 'docker build . -t ${IMG}' with '-t ${IMG} .' 

    Because folks may have 'docker' aliased to 'podman', and Podman
prefers options before positional arguments [1]:

  $ podman build --help | grep CONTEXT-DIRECTORY
     podman build [command options] CONTEXT-DIRECTORY | URL

Generated with:

  $ sed -i 's/ . -t \([^ ]*\)/ -t \1 ./' $(git grep -l 'docker.*build.* \. ')
  $ git checkout HEAD -- docs
  $ git checkout HEAD -- pkg/plugin/v2 testdata/project-v2*

The docs checkout leaves historical docs alone [2,3,4].  The v2
checkouts are because Adrián and Camila consider this minor and not
worth fixing in v2 [5].

[1]: containers/podman#2811
[2]: kubernetes-sigs#1817 (comment)
[3]: kubernetes-sigs#1817 (comment)
[4]: kubernetes-sigs#1817 (comment)
[5]: kubernetes-sigs#1817 (comment)
    @wking
    wking committed Nov 16, 2020
    Configuration menu
    Copy the full SHA
    ccb1127 View commit details
    Browse the repository at this point in the history