🐛 Fix --force option to recreate the files by kubebuilder create api #1847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/test pull-kubebuilder-e2e-k8s-1-16-2 |
k8s-ci-robot
added
the
needs-rebase
k8s-ci-robot
removed
the
needs-rebase
|
/cc @camilamacedo86 |
camilamacedo86
approved these changes
Dec 7, 2020
k8s-ci-robot
added
the
approved
|
@camilamacedo86 There is no --force option in create webhook command, hence for webhook this will be Feature request. Hence, that should be done in a separate PR and only for V3. Will raise a different PR for that |
k8s-ci-robot
added
do-not-merge/hold
|
we bug triage the issue today. So, it shows fine we /lgtm this one. Very reasonable for me as well. |
camilamacedo86
added
the
lgtm
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, prafull01 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added changes to overwrite the files generated by kubebuilder create api when --force option is provided.
Motivation
--force command is failing on kubebuilder
Fixes: #1845