Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Change the webhook GVK in help text to match kb create api #1881

Merged
merged 1 commit into from
Dec 7, 2020

Conversation

prafull01
Copy link
Contributor

@prafull01 prafull01 commented Dec 4, 2020

Description
Change the help text on create webhook command to match the create api command.

Motivation
Users who is trying out kubebuilder layout with the --help command should able to run the commands generated by kubebuilder --help. Hence, the create api command GVK and create command GVK should be same in the help text.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 4, 2020
@prafull01 prafull01 changed the title 👻 Change the webhook GVK in help text to match kb create api ✨ Change the webhook GVK in help text to match kb create api Dec 4, 2020
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with 👍

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2020
@camilamacedo86
Copy link
Member

Also, I think we can do that for v2 as well. @Adirio @gabbifish thoughts?

Copy link
Contributor

@Adirio Adirio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the help message for v2 should be doable yes.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Adirio, camilamacedo86, prafull01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@camilamacedo86
Copy link
Member

Hi @prafull01,

Could you please update v2 as well for we are able to get this one merged?

@k8s-ci-robot
Copy link
Contributor

@prafull01: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubebuilder-e2e-k8s-1-17-0 511258b link /test pull-kubebuilder-e2e-k8s-1-17-0

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@prafull01
Copy link
Contributor Author

/test pull-kubebuilder-e2e-k8s-1-17-0

Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2020
@k8s-ci-robot k8s-ci-robot merged commit 37d8201 into kubernetes-sigs:master Dec 7, 2020
@prafull01 prafull01 deleted the help-text branch December 7, 2020 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants