Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ (go/v3) stabilize and default the plugin #1882

Merged
merged 1 commit into from
Dec 14, 2020

Conversation

estroz
Copy link
Contributor

@estroz estroz commented Dec 5, 2020

This PR stabilizes plugin go/v3-alpha to go/v3 and makes it the default plugin.

  • cmd/main.go: make go/v3 the default plugin
  • *.sh: update tests to create projects for the correct plugin version

Closes #1834

the default plugin.

cmd/main.go: make go/v3 the default plugin

*: update tests to create projects for the correct plugin version
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 5, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 5, 2020
@estroz
Copy link
Contributor Author

estroz commented Dec 5, 2020

This is blocked by #1746

@estroz estroz changed the title [WIP] ⚠️ (go/v3) stabilize plugin [WIP] ⚠️ (go/v3) stabilize and default the plugin Dec 5, 2020
@Adirio
Copy link
Contributor

Adirio commented Dec 7, 2020

Just a question: why is it blocked bu CR 0.7.0?

@estroz
Copy link
Contributor Author

estroz commented Dec 8, 2020

Just a question: why is it blocked bu CR 0.7.0?

I suppose it doesn't need to be since alpha releases will be cut soon.

@estroz estroz changed the title [WIP] ⚠️ (go/v3) stabilize and default the plugin ⚠️ (go/v3) stabilize and default the plugin Dec 10, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 10, 2020
@Adirio
Copy link
Contributor

Adirio commented Dec 10, 2020

/hold until v3.0.0

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 10, 2020
Copy link
Contributor

@Adirio Adirio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Adirio, estroz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@estroz
Copy link
Contributor Author

estroz commented Dec 14, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 14, 2020
@k8s-ci-robot k8s-ci-robot merged commit 0a807f4 into kubernetes-sigs:master Dec 14, 2020
@estroz estroz deleted the feature/stabilize-go-v3 branch December 14, 2020 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make v3-alpha plugin as stable (only for the stable release)
3 participants