-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add the unit tests in pkg/model/config/config_test.go for HasWebhook #1909
🌱 Add the unit tests in pkg/model/config/config_test.go for HasWebhook #1909
Conversation
/test pull-kubebuilder-e2e-k8s-1-17-0 |
/cc @camilamacedo86 |
/test pull-kubebuilder-e2e-k8s-1-17-0 |
pkg/model/config/config_test.go
Outdated
Expect(c.Resources).To(Equal([]ResourceData{gvk3})) | ||
Expect(c.HasWebhook(gvk3)).To(BeTrue()) | ||
}) | ||
It("should return false when config has a webhook with the GVK", func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It("should return false when config has a webhook with the GVK", func() { | |
It("should return false when config has NOT a webhook with the GVK", func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
42123a8
to
9b8f369
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some english related comments:
9b8f369
to
258470c
Compare
@Adirio Fixed those. |
Hi @prafull01, All fine here. Since we are only adding tests the correct mojo is: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, prafull01 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Add the HasWebhook() unit tests to improve the coverage.
Motivation
Follow up of the PR #1903 where the HasWebhook() function is introduced.