🌱 Add the unit tests in pkg/model/config/config_test.go for HasWebhook #1909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/test pull-kubebuilder-e2e-k8s-1-17-0 |
|
/cc @camilamacedo86 |
|
/test pull-kubebuilder-e2e-k8s-1-17-0 |
pkg/model/config/config_test.go
Outdated
| Expect(c.Resources).To(Equal([]ResourceData{gvk3})) | ||
| Expect(c.HasWebhook(gvk3)).To(BeTrue()) | ||
| }) | ||
| It("should return false when config has a webhook with the GVK", func() { |
There was a problem hiding this comment.
Suggested change
| It("should return false when config has a webhook with the GVK", func() { | |
| It("should return false when config has NOT a webhook with the GVK", func() { |
prafull01
force-pushed
the
config-unit-test
branch
from
42123a8
to
9b8f369
Compare
Adirio
suggested changes
Dec 16, 2020
prafull01
force-pushed
the
config-unit-test
branch
from
9b8f369
to
258470c
Compare
@Adirio Fixed those. |
|
Hi @prafull01, All fine here. Since we are only adding tests the correct mojo is: |
camilamacedo86
changed the title
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, prafull01 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the HasWebhook() unit tests to improve the coverage.
Motivation
Follow up of the PR #1903 where the HasWebhook() function is introduced.