Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 upgrade migration guide for v3 #1916

Merged
merged 1 commit into from
Feb 12, 2021
Merged

📖 upgrade migration guide for v3 #1916

merged 1 commit into from
Feb 12, 2021

Conversation

camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented Dec 17, 2020 •
edited

Description

  • upgrade the migration guide with the steps required for v3 so far

To review

Check in the preview link: https://deploy-preview-1916--kubebuilder.netlify.app/migration/v2vsv3.html

Closes: #1829

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 17, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 17, 2020
@camilamacedo86 camilamacedo86 force-pushed the migration-doc branch 7 times, most recently from 58a8930 to dda4bfe Compare December 17, 2020 22:19
@camilamacedo86 camilamacedo86 changed the title 📖 upgrade migration guide for v3-alpha 📖 upgrade migration guide for v3 Dec 17, 2020
@camilamacedo86 camilamacedo86 force-pushed the migration-doc branch 2 times, most recently from 5fdefa2 to 6e9f0b3 Compare December 18, 2020 08:58
darkowlzz
darkowlzz reviewed Dec 21, 2020
View reviewed changes
Copy link

@darkowlzz darkowlzz left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this migration guide. I learned a lot reading through it.
It's a lot and I tried suggesting some improvements wherever I noticed. Hope they are useful. 🙂

docs/book/src/migration/migration_guide_v2tov3.md Outdated Show resolved Hide resolved
docs/book/src/migration/migration_guide_v2tov3.md Outdated Show resolved Hide resolved
docs/book/src/migration/migration_guide_v2tov3.md Outdated Show resolved Hide resolved
docs/book/src/migration/migration_guide_v2tov3.md Outdated Show resolved Hide resolved
docs/book/src/migration/migration_guide_v2tov3.md Show resolved Hide resolved
docs/book/src/migration/plugin/v2_v3.md Outdated Show resolved Hide resolved
docs/book/src/migration/plugin/v2_v3.md Outdated Show resolved Hide resolved
docs/book/src/migration/plugin/v2_v3.md Outdated Show resolved Hide resolved
docs/book/src/migration/plugin/v2_v3.md Outdated Show resolved Hide resolved
docs/book/src/migration/plugin/v2_v3.md Outdated Show resolved Hide resolved
@camilamacedo86 camilamacedo86 force-pushed the migration-doc branch 4 times, most recently from 002d811 to a194af6 Compare December 21, 2020 16:37
@k8s-ci-robot
Copy link
Contributor

@ChiefyG-Admin: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-kubebuilder-test
  • /test pull-kubebuilder-e2e-k8s-1-18-0
  • /test pull-kubebuilder-e2e-k8s-1-17-0
  • /test pull-kubebuilder-e2e-k8s-1-16-2
  • /test pull-kubebuilder-e2e-k8s-1-15-3
  • /test pull-kubebuilder-e2e-k8s-1-14-1

Use /test all to run all jobs.

In response to this:

/test if u think it's good then go for it and test it
M

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@camilamacedo86
Copy link
Member Author

/hold

Until to get enough approvals/reviews.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 23, 2020
This was referenced Jan 12, 2021
Closed
Closed
@camilamacedo86 camilamacedo86 modified the milestone: v3.0.0 Jan 12, 2021
@pwittrock
Copy link
Contributor

I don't have enough context on v2 vs v3. don't block on my approval

@camilamacedo86 camilamacedo86 force-pushed the migration-doc branch 3 times, most recently from cbdfbbc to 964ebe1 Compare February 11, 2021 18:34
@camilamacedo86
Copy link
Member Author

/test pull-kubebuilder-e2e-k8s-1-19-4

@camilamacedo86
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 11, 2021
@camilamacedo86 camilamacedo86 dismissed DirectXMan12’s stale review February 11, 2021 18:44

all suggestion are addressed

@jberkhahn
Copy link
Contributor

@camilamacedo86 some comments

jberkhahn
jberkhahn reviewed Feb 11, 2021
View reviewed changes
docs/book/src/migration/migration_guide_v2tov3.md Outdated Show resolved Hide resolved
docs/book/src/migration/migration_guide_v2tov3.md Outdated Show resolved Hide resolved
docs/book/src/migration/migration_guide_v2tov3.md Outdated Show resolved Hide resolved
docs/book/src/migration/migration_guide_v2tov3.md Outdated Show resolved Hide resolved
docs/book/src/migration/v2vsv3.md Outdated Show resolved Hide resolved
docs/book/src/migration/v2vsv3.md Outdated Show resolved Hide resolved
docs/book/src/migration/v2vsv3.md Outdated Show resolved Hide resolved
docs/book/src/migration/v2vsv3.md Outdated Show resolved Hide resolved
jmrodri
jmrodri requested changes Feb 11, 2021
View reviewed changes
Copy link
Contributor

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite a few suggestions to reword and make things a little more clear.

docs/book/src/migration/manually_migration_guide_v2_v3.md Outdated Show resolved Hide resolved
docs/book/src/migration/manually_migration_guide_v2_v3.md Outdated Show resolved Hide resolved
docs/book/src/migration/manually_migration_guide_v2_v3.md Outdated Show resolved Hide resolved
docs/book/src/migration/manually_migration_guide_v2_v3.md Outdated Show resolved Hide resolved
docs/book/src/migration/manually_migration_guide_v2_v3.md Outdated Show resolved Hide resolved
docs/book/src/migration/manually_migration_guide_v2_v3.md Outdated Show resolved Hide resolved
docs/book/src/migration/manually_migration_guide_v2_v3.md Outdated Show resolved Hide resolved
docs/book/src/migration/manually_migration_guide_v2_v3.md Outdated Show resolved Hide resolved
docs/book/src/migration/manually_migration_guide_v2_v3.md Outdated Show resolved Hide resolved
docs/book/src/migration/migration_guide_v2tov3.md Outdated Show resolved Hide resolved
@camilamacedo86 camilamacedo86 force-pushed the migration-doc branch 6 times, most recently from 6d3c784 to 33f8d43 Compare February 12, 2021 17:15
@jmrodri
Copy link
Contributor

jmrodri commented Feb 12, 2021

/lgtm

Nice work @camilamacedo86

@k8s-ci-robot
Copy link
Contributor

@jmrodri: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Nice work @camilamacedo86

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sftim
Copy link

sftim commented Feb 12, 2021

/kind documentation
?

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Feb 12, 2021
@pwittrock
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2021
@k8s-ci-robot k8s-ci-robot merged commit 685558d into kubernetes-sigs:master Feb 12, 2021
@camilamacedo86 camilamacedo86 deleted the migration-doc branch February 12, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmathieu dmathieu dmathieu left review comments

@jmrodri jmrodri jmrodri requested changes

@darkowlzz darkowlzz darkowlzz left review comments

@jberkhahn jberkhahn jberkhahn left review comments

@LCaparelli LCaparelli LCaparelli left review comments

@fmuyassarov fmuyassarov fmuyassarov left review comments

@varshaprasad96 varshaprasad96 varshaprasad96 left review comments

@ChiefGhostZero0x1 ChiefGhostZero0x1 ChiefGhostZero0x1 left review comments

@droot droot Awaiting requested review from droot

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

@Adirio Adirio Awaiting requested review from Adirio

@coderanger coderanger Awaiting requested review from coderanger

Assignees

@pwittrock pwittrock

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the migration doc with the latest changes for v3+ plugin