-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 upgrade migration guide for v3 #1916
📖 upgrade migration guide for v3 #1916
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
58a8930
to
dda4bfe
Compare
5fdefa2
to
6e9f0b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for writing this migration guide. I learned a lot reading through it.
It's a lot and I tried suggesting some improvements wherever I noticed. Hope they are useful. 🙂
002d811
to
a194af6
Compare
@ChiefyG-Admin: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold Until to get enough approvals/reviews. |
a194af6
to
d69fdca
Compare
I don't have enough context on v2 vs v3. don't block on my approval |
cbdfbbc
to
964ebe1
Compare
/test pull-kubebuilder-e2e-k8s-1-19-4 |
/hold cancel |
all suggestion are addressed
964ebe1
to
9b09c22
Compare
@camilamacedo86 some comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quite a few suggestions to reword and make things a little more clear.
6d3c784
to
33f8d43
Compare
33f8d43
to
ab3bb7f
Compare
/lgtm Nice work @camilamacedo86 |
@jmrodri: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind documentation |
/lgtm |
Description
To review
Check in the preview link: https://deploy-preview-1916--kubebuilder.netlify.app/migration/v2vsv3.html
Closes: #1829