Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add help dialog to makefile template #1947

Merged
merged 2 commits into from
Jan 14, 2021

Conversation

droctothorpe
Copy link
Contributor

@droctothorpe droctothorpe commented Jan 14, 2021

This PR:

  • Recycles the self-documenting help target from the base Makefile into the makefile template that's rendered when kubebuilder init is invoked.
  • Relocates the target descriptions in the template so that they can be leveraged by the help target.
  • Corrects some minor typos and long lines in the base Makefile.

This PR closes: #1867

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 14, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @droctothorpe!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @droctothorpe. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 14, 2021
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 14, 2021
Copy link
Contributor

@Adirio Adirio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 14, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 14, 2021
@Adirio
Copy link
Contributor

Adirio commented Jan 14, 2021

Out of curiosity, has the help description been tested under nawk (New awk), gawk (GNU awk) and mawk (Mike's awk)? We are supporting iOS and I think they use a different implementation of awk.

@droctothorpe
Copy link
Contributor Author

Out of curiosity, has the help description been tested under nawk (New awk), gawk (GNU awk) and mawk (Mike's awk)? We are supporting iOS and I think they use a different implementation of awk.

I did not test it with nawk, gawk, and mawk since I recycled the awk implementation in the base Makefile. The update would need to happen in both places. Would you like that work to be part of this PR?

@Adirio
Copy link
Contributor

Adirio commented Jan 14, 2021

Would you like that work to be part of this PR?

No, it was just curiosity. You just need an approver to set the corresponding label, I already set the lgtm one.

@camilamacedo86
Copy link
Member

This PR closes: #1867

@Adirio
Copy link
Contributor

Adirio commented Jan 14, 2021

This PR closes: #1867

@droctothorpe could you add this to the description so that the bot closes it to when merged?

@droctothorpe
Copy link
Contributor Author

This PR closes: #1867

@droctothorpe could you add this to the description so that the bot closes it to when merged?

Done. Thank you!

@camilamacedo86
Copy link
Member

We might decide to improve the help text and add categories in the future. However, it is great. Really thank you for your contribution:

Screen Shot 2021-01-14 at 17 25 12

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2021
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thank you for your contribution.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Adirio, camilamacedo86, droctothorpe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f7a5201 into kubernetes-sigs:master Jan 14, 2021
@droctothorpe droctothorpe deleted the makefile-updates branch January 15, 2021 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Suggestion] Make help printing available operations
4 participants