Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 update the docs over regards book-v3 branch #1960

Merged
merged 1 commit into from
Apr 27, 2021
Merged

📖 update the docs over regards book-v3 branch #1960

merged 1 commit into from
Apr 27, 2021

Conversation

camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented Jan 18, 2021 •
edited
Loading

Description

  • Update the docs to have the info over the latest branch that tough to be used to v3

Motivation

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 18, 2021
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 18, 2021
@camilamacedo86 camilamacedo86 mentioned this pull request Jan 18, 2021
Closed
Adirio
Adirio approved these changes Jan 29, 2021
View reviewed changes
Copy link
Contributor

@Adirio Adirio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting on the comment above, the rest LGTM

Adirio
Adirio reviewed Feb 1, 2021
View reviewed changes
VERSIONING.md Show resolved Hide resolved
@Adirio

This comment has been minimized.

Sign in to view
@k8s-ci-robot
Copy link
Contributor

@camilamacedo86: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 24, 2021
@Adirio
Copy link
Contributor

Adirio commented Mar 24, 2021

Rebase and squash required

estroz
estroz reviewed Apr 22, 2021
View reviewed changes
CONTRIBUTING.md Outdated
- `book-v2`: [book.kubebuilder.io](https://book.kubebuilder.io) -- current
docs
- `book-v3`: [book.kubebuilder.io](https://book.kubebuilder.io) -- current docs
- `book-v2`: [book-v2.kubebuilder.io](https://book-v2.kubebuilder.io) -- legacy docs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This subdomain does not exist yet. I think a netlify mapping is needed.

estroz
estroz approved these changes Apr 27, 2021
View reviewed changes
Copy link
Contributor

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Adirio, camilamacedo86, estroz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Adirio,camilamacedo86,estroz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2021
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 27, 2021
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 27, 2021
@estroz
Copy link
Contributor

estroz commented Apr 27, 2021

/lgtm
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2021
@estroz estroz removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 27, 2021
@k8s-ci-robot k8s-ci-robot merged commit 33ca7eb into kubernetes-sigs:master Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adirio Adirio Adirio approved these changes

@estroz estroz estroz approved these changes

@mengqiy mengqiy Awaiting requested review from mengqiy

Assignees

@estroz estroz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should we create the branch book-v3 for the 3.0.0 release?
4 participants
@camilamacedo86 @Adirio @k8s-ci-robot @estroz