✨ bump controller-runtime to 0.8.3

[varshaprasad96]

deps: Bump controller-runtime to 0.8.0

[k8s-ci-robot]

Hi @varshaprasad96. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[varshaprasad96]

Blocked on #146. Need to regenerate test data for project-v3-addon and project-v3-config plugins.

[Adirio]

Note: current PR title and description checks do not understand the [WIP] part, so they will fail anyway, but once you remove it, the emoji (✨ :sparkles:) is expected without brackets, so you will also have to remove those.

P.S.: the next version of the PR title verifier will understand the [WIP] prefix.

[varshaprasad96]

The PR has been updated. Waiting for v3.0.0 release.
/hold

[Adirio]

@varshaprasad96 Could you remove the brackets from the title's emoji? Either ✨ or :sparkles: is fine, (and GitHub started understanding emojis on titles).

[camilamacedo86]

HI @estroz,

You spoke about we push it in 3.1.0. However, wdyt? Could it get merged now or should we wait? if it gets merged than it means that if we need to rebase master with the release-v3 before 3.0.0 it will ship as well. I have not an objection at all with 3.0.0 be using controller-runtime 0.8.0.

c/c @Adirio

[Adirio]

The reason that was given (I think it was @estroz but not 100% sure) was that there is no kubebuilder version that supports v0.7.0 which is the first version supporting kubernetes 1.19.x so that it would be nicer to have a v3.0.0 with v0.7.0 and then upgrade it for v3.1.0.

[Adirio]

/ok-to-test

[camilamacedo86]

I am ok with it get merged. I do not think that would be a requirement we have any version of the tool using 0.7.0.

@varshaprasad96 could you only please update the migration doc and bump the version 0.8.0 where we have 0.7.0?

c/c @estroz

[varshaprasad96]

Based on the discussion, I am reverting the migration doc changes, since the default version for v3 stable would be c-r 0.7.0

[estroz]

since the default version for v3 stable would be c-r 0.7.0

@varshaprasad96 yes but after this PR merges it will be 0.8.0 right?

[Adirio]

Even if the docs are changed in master they won't get reflected in the published book until a new release that contains this merged PR is made, and then the version would be 0.8.0.

[camilamacedo86]

@varshaprasad96 @estroz,

This PR bumps the controller-runtime to 0.8.0
When it gets merged we need also update the docs
The production docs are only updated as part of the release where we push the master changes to the book branch. So, the master docs need to reflect the master state and update the doc is part of the PR. If we need to revert we will also revert the docs changes.

Is it make sense?

[varshaprasad96]

Sorry, got confused ! Updated the migration docs

[camilamacedo86]

We need also have the commits squashed as well.

[estroz]

@varshaprasad96 this can be rebased and bumped to controller-runtime v0.8.3

[varshaprasad96]

@estroz Done. bumped to controller-runtime v0.8.3

stale

[estroz]

/approve
/lgtm
/hold cancel

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Adirio, estroz, varshaprasad96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Adirio,estroz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

@varshaprasad96: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-kubebuilder-e2e-k8s-1-19-4	12f9460	link	/test pull-kubebuilder-e2e-k8s-1-19-4

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[estroz]

/retest