-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Remove make calls from post-scaffold hooks #1983
✨ Remove make calls from post-scaffold hooks #1983
Conversation
Signed-off-by: Adrian Orive <adrian.orive.oneca@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO I do not think that we should move with this one. see: #1982 (comment)
Also, the changes here a breaking changes fo v2 too :-( .
/hold
Based on the clarifications #1982 it shows fine and has no reason for us not: |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Adirio, camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
Remove non-needed calls to
make
at the end of different command calls.Closes: #1982