馃悰 (config/v3) Track in the project configuration file resources without API #2003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/L
Adirio
force-pushed
the
track-resources-without-api
branch
2 times, most recently
from
2af85b9
to
0358291
Compare
Adirio
commented
Feb 10, 2021
| @@ -98,7 +98,7 @@ scaffold_test_project() { | |||
|
|
|||
| $kb create api --group foo.policy --version v1 --kind HealthCheckPolicy --controller=true --resource=true --make=false | |||
|
|
|||
| $kb create api --group apps --version v1 --kind Pod --controller=true --resource=false --make=false | |||
| $kb create api --group apps --version v1 --kind Deployment --controller=true --resource=false --make=false | |||
Adirio
force-pushed
the
track-resources-without-api
branch
4 times, most recently
from
a63f8c4
to
d4371e8
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Adirio
force-pushed
the
track-resources-without-api
branch
from
d4371e8
to
7bcbb70
Compare
- Remove path from resources that do not know the path - Add scaffold to controllers if we do know the path instead of if we scaffold an API - Track the resources in the config file even if we don't scaffold an API Signed-off-by: Adrian Orive <adrian.orive.oneca@gmail.com>
Adirio
force-pushed
the
track-resources-without-api
branch
from
7bcbb70
to
42091e9
Compare
Adirio
changed the title
camilamacedo86
approved these changes
Feb 11, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Adirio, camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an API is not scaffolded (
kubebuilder create api --resource=false --controller ...) the resources are not being tracked in the config file. Tracking this inconfig/v3is doable as we can still know if the API was scaffolded by some of its fields, but asconfig/v2doesn't have this additional fields, it can't track this resources. The reason for this is that the pressence of a resource inconfig/v2means that the API was scaffolded at webhook validation (they require the API to be scaffolded) and this information won't be obtainable.This change also detected that we were defining the
Pathfield for those resources that do not have an API which was removed, and it allows to be a bit more intelligent when deploying core-resources.Fixes #2001
Fixes #2002