Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable test for existing projects in travis #206

Merged
merged 1 commit into from
May 23, 2018
Merged

Enable test for existing projects in travis #206

merged 1 commit into from
May 23, 2018

Conversation

Liujingfang1
Copy link
Contributor

@Liujingfang1 Liujingfang1 commented May 22, 2018 •
edited

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 22, 2018
@Liujingfang1 Liujingfang1 force-pushed the master branch 2 times, most recently from 33ba3a7 to e5ad85f Compare May 23, 2018 17:14
droot
droot reviewed May 23, 2018
View reviewed changes
.travis.yml Outdated
@@ -22,7 +22,8 @@ install:
-

script:
TRACE=1 ./test.sh
- TRACE=1 ./test.sh
- go test -v ./samples/memcached-api-server
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have a scripts which loops over all the tests and invoke go test. Then people don't have to change the travis config everytime they add a test project.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 23, 2018
@Liujingfang1 Liujingfang1 changed the title WIP Enable test for existing projects in travis Enable test for existing projects in travis May 23, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 23, 2018
@Liujingfang1
Copy link
Contributor Author

Add a bash script to call go test. In the future, when new project is added, we just need to add an extra line in this script as
go test -v <new project directory>

@droot droot merged commit 123e075 into kubernetes-sigs:master May 23, 2018
@Liujingfang1 Liujingfang1 mentioned this pull request May 23, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droot droot droot approved these changes

@pwittrock pwittrock Awaiting requested review from pwittrock

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Liujingfang1 @droot @k8s-ci-robot