Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 test/e2e: export KIND_CLUSTER so local tests get correct cluster name #2071

Merged
merged 1 commit into from
Mar 9, 2021
Merged

🌱 test/e2e: export KIND_CLUSTER so local tests get correct cluster name #2071

merged 1 commit into from
Mar 9, 2021

Conversation

estroz
Copy link
Contributor

@estroz estroz commented Mar 9, 2021

Local e2e tests do not receive the correct cluster name as KIND_CLUSTER is not set.

  • test/e2e: export KIND_CLUSTER so local tests get correct cluster name

@estroz estroz added the testing label Mar 9, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 9, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2021
@estroz
Copy link
Contributor Author

estroz commented Mar 9, 2021

/cc @Adirio

@k8s-ci-robot k8s-ci-robot requested a review from Adirio March 9, 2021 03:34
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Adirio, estroz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@estroz
test/e2e: export KIND_CLUSTER so local tests get correct cluster name
9a121a1 
Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
@estroz estroz force-pushed the chore/correct-test-cluster-name branch from 39c3b46 to 9a121a1 Compare March 9, 2021 20:20
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 9, 2021
@Adirio
Copy link
Contributor

Adirio commented Mar 9, 2021

/retest

@Adirio Adirio mentioned this pull request Mar 9, 2021
Merged
@Adirio
Copy link
Contributor

Adirio commented Mar 9, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2021
@k8s-ci-robot k8s-ci-robot merged commit b6e2ead into kubernetes-sigs:master Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adirio Adirio Adirio approved these changes

@camilamacedo86 camilamacedo86 Awaiting requested review from camilamacedo86

@droot droot Awaiting requested review from droot

Assignees

@Adirio Adirio

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@estroz @k8s-ci-robot @Adirio