-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Export config machinery #2083
🌱 Export config machinery #2083
Conversation
Skipping CI for Draft Pull Request. |
/test all |
dff314c
to
8615106
Compare
- Store interface and YAML implementation for current usage - Use PreRunE and PostRunE functions to handle configuration file loading and saving Signed-off-by: Adrian Orive <adrian.orive.oneca@gmail.com>
8615106
to
f7ad796
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The blocked pr #2080 is merged. It is not a breaking change and it shows currently a requirement for we better address 1.5 plugin implementation and remove its duplication on SDK side.
Also, it was discussed in the meetings and no objections were raised.
So, I am ok with this one. Thank you for the collab 🥇
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Adirio, camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I don't think that this PR has any breaking changes
Closes: #2056
Blocked by: #2080