✨ add new plugin `go-config-gen/v1` #2099

estroz · 2021-03-18T02:20:54Z

This PR adds the go-config-gen/v1 plugin, which uses the recently merged alpha config-gen to configure a project. All Go code is untouched, so perhaps this idea is a good candidate for a config-only plugin as suggested in #2015.

This plugin has two modes:

Use config-gen directly with kubebuilder alpha config-gen, which will write the configgen and componentconfig manifests to the top level.

kubebuilder init --plugins go-config-gen

Use through kustomize build --enable-alpha-plugins, which will write a configgen, componentconfig, and kustomization.yaml to ./config/configgen, and a kustomization.yaml to ./config/default that calls ../configgen

kubebuilder init --plugins go-config-gen --with-kustomize

The code in this PR is experimental and probably won't merge for awhile.

/kind feature

k8s-ci-robot · 2021-03-18T02:21:00Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: estroz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [estroz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

estroz · 2021-03-18T02:21:32Z

/cc @pwittrock

estroz · 2021-03-18T06:12:23Z

I'm now on the fence about whether to scaffold kustomization.yaml's by default and provide --no-kustomize, or stick with --with-kustomize. I imagine most users will eventually migrate to using kustomize, and the base kustomize scaffold is quite simple right now.

camilamacedo86 · 2021-03-18T14:50:39Z

cmd/main.go

@@ -22,6 +22,7 @@ import (
 	"sigs.k8s.io/kubebuilder/v3/pkg/cli"
 	cfgv2 "sigs.k8s.io/kubebuilder/v3/pkg/config/v2"
 	cfgv3 "sigs.k8s.io/kubebuilder/v3/pkg/config/v3"
+	goconfiggenv1 "sigs.k8s.io/kubebuilder/v3/pkg/plugins/golang-config-gen/v1"


Let's use alpha here as well go-config-gen/alphav1 until it gets mature enough to be v1.

The package name doesn't really matter IMO, since the plugin has a v1-alpha version.

I think that matter because:

make explicitly that is in alpha for maintainers and consumers

kb is also a lib/api and we need to make it clear that we can break everything that we wish with this one.

pwittrock · 2021-03-18T16:58:37Z

For the non-config-gen specific scaffolding, is it possible to simply reference another package?

estroz · 2021-03-18T17:29:34Z

@pwittrock I should be able to move the plugin directory into a subdir of pkg/plugins/golang/v3 to access the internal directory containing scaffolds so I can re-use some of them. That should slim down the changes here significantly.

pkg/plugins/golang-config-gen/v1/api.go

pkg/cli/alpha/config-gen/cmd.go

camilamacedo86 · 2021-03-18T18:14:03Z

..

estroz · 2021-04-14T17:51:45Z

testdata/project-v3-config-gen/controllers/suite_test.go

+
+	By("bootstrapping test environment")
+	testEnv = &envtest.Environment{
+		CRDDirectoryPaths:     []string{filepath.Join("..", "config", "crd", "bases")},


This still needs to be changed.

…-alpha Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>

k8s-ci-robot · 2021-04-16T10:14:10Z

@estroz: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fejta-bot · 2021-07-17T00:05:42Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

k8s-triage-robot · 2021-08-16T00:25:59Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot · 2021-09-15T00:46:18Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Reopen this issue or PR with /reopen
Mark this issue or PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2021-09-15T00:46:26Z

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Reopen this issue or PR with /reopen

Mark this issue or PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 18, 2021

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 18, 2021

k8s-ci-robot requested review from DirectXMan12 and joelanford March 18, 2021 02:21

estroz marked this pull request as draft March 18, 2021 02:21

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 18, 2021

k8s-ci-robot requested a review from pwittrock March 18, 2021 02:21

estroz changed the title ~~✨ (experimental) add new plugin 'golang-config-gen/v1'~~ ✨ (experimental) add new plugin go-config-gen/v1 Mar 18, 2021

estroz force-pushed the feature/config-gen-plugin branch from 15ebcde to ed158f3 Compare March 18, 2021 06:47

camilamacedo86 reviewed Mar 18, 2021

View reviewed changes

pkg/plugins/golang-config-gen/v1/api.go Outdated Show resolved Hide resolved

estroz commented Mar 18, 2021

View reviewed changes

pkg/cli/alpha/config-gen/cmd.go Outdated Show resolved Hide resolved

estroz force-pushed the feature/config-gen-plugin branch from 1675d60 to ee0eb16 Compare March 18, 2021 18:08

estroz mentioned this pull request Mar 18, 2021

✨ config-gen create and bind to a non-default service account #2085

Closed

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 19, 2021

estroz force-pushed the feature/config-gen-plugin branch from ee0eb16 to c62c10e Compare April 14, 2021 00:54

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 14, 2021

estroz force-pushed the feature/config-gen-plugin branch 3 times, most recently from 93cec06 to d34043d Compare April 14, 2021 17:40

estroz commented Apr 14, 2021

View reviewed changes

estroz changed the title ~~✨ (experimental) add new plugin go-config-gen/v1~~ ✨ add new plugin go-config-gen/v1 Apr 14, 2021

add new plugin config-gen.common/v1-alpha and bundle config-gen.go/v1…

a03f10a

…-alpha Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>

estroz force-pushed the feature/config-gen-plugin branch from d34043d to a03f10a Compare April 14, 2021 19:47

estroz marked this pull request as ready for review April 14, 2021 19:49

k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Apr 14, 2021

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 17, 2021

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 16, 2021

k8s-ci-robot closed this Sep 15, 2021

This was referenced Mar 21, 2022

✨ New plugin for config-gen as alpha. #2540

Closed

Move config-gen to a alpha plugin design #2501

Closed

camilamacedo86 mentioned this pull request Oct 5, 2022

Create a new plugin OR a new project with config-gen option #3000

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ add new plugin `go-config-gen/v1` #2099

✨ add new plugin `go-config-gen/v1` #2099

estroz commented Mar 18, 2021 •

edited

Loading

k8s-ci-robot commented Mar 18, 2021

estroz commented Mar 18, 2021

estroz commented Mar 18, 2021

camilamacedo86 Mar 18, 2021

estroz Mar 18, 2021

camilamacedo86 Mar 18, 2021

pwittrock commented Mar 18, 2021

estroz commented Mar 18, 2021

camilamacedo86 commented Mar 18, 2021 •

edited

Loading

estroz Apr 14, 2021

k8s-ci-robot commented Apr 16, 2021

fejta-bot commented Jul 17, 2021

k8s-triage-robot commented Aug 16, 2021

k8s-triage-robot commented Sep 15, 2021

k8s-ci-robot commented Sep 15, 2021

✨ add new plugin go-config-gen/v1 #2099

✨ add new plugin go-config-gen/v1 #2099

Conversation

estroz commented Mar 18, 2021 • edited Loading

k8s-ci-robot commented Mar 18, 2021

estroz commented Mar 18, 2021

estroz commented Mar 18, 2021

camilamacedo86 Mar 18, 2021

Choose a reason for hiding this comment

estroz Mar 18, 2021

Choose a reason for hiding this comment

camilamacedo86 Mar 18, 2021

Choose a reason for hiding this comment

pwittrock commented Mar 18, 2021

estroz commented Mar 18, 2021

camilamacedo86 commented Mar 18, 2021 • edited Loading

estroz Apr 14, 2021

Choose a reason for hiding this comment

k8s-ci-robot commented Apr 16, 2021

fejta-bot commented Jul 17, 2021

k8s-triage-robot commented Aug 16, 2021

k8s-triage-robot commented Sep 15, 2021

k8s-ci-robot commented Sep 15, 2021

✨ add new plugin `go-config-gen/v1` #2099

✨ add new plugin `go-config-gen/v1` #2099

estroz commented Mar 18, 2021 •

edited

Loading

camilamacedo86 commented Mar 18, 2021 •

edited

Loading