-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ add new plugin go-config-gen/v1
#2099
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: estroz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @pwittrock |
go-config-gen/v1
I'm now on the fence about whether to scaffold kustomization.yaml's by default and provide |
15ebcde
to
ed158f3
Compare
cmd/main.go
Outdated
@@ -22,6 +22,7 @@ import ( | |||
"sigs.k8s.io/kubebuilder/v3/pkg/cli" | |||
cfgv2 "sigs.k8s.io/kubebuilder/v3/pkg/config/v2" | |||
cfgv3 "sigs.k8s.io/kubebuilder/v3/pkg/config/v3" | |||
goconfiggenv1 "sigs.k8s.io/kubebuilder/v3/pkg/plugins/golang-config-gen/v1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use alpha here as well go-config-gen/alphav1
until it gets mature enough to be v1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package name doesn't really matter IMO, since the plugin has a v1-alpha
version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that matter because:
- make explicitly that is in alpha for maintainers and consumers
- kb is also a lib/api and we need to make it clear that we can break everything that we wish with this one.
For the non-config-gen specific scaffolding, is it possible to simply reference another package? |
@pwittrock I should be able to move the plugin directory into a subdir of |
1675d60
to
ee0eb16
Compare
.. |
ee0eb16
to
c62c10e
Compare
93cec06
to
d34043d
Compare
|
||
By("bootstrapping test environment") | ||
testEnv = &envtest.Environment{ | ||
CRDDirectoryPaths: []string{filepath.Join("..", "config", "crd", "bases")}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still needs to be changed.
go-config-gen/v1
go-config-gen/v1
…-alpha Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
d34043d
to
a03f10a
Compare
@estroz: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR adds the
go-config-gen/v1
plugin, which uses the recently mergedalpha config-gen
to configure a project. All Go code is untouched, so perhaps this idea is a good candidate for a config-only plugin as suggested in #2015.This plugin has two modes:
Use
config-gen
directly withkubebuilder alpha config-gen
, which will write the configgen and componentconfig manifests to the top level.Use through
kustomize build --enable-alpha-plugins
, which will write a configgen, componentconfig, and kustomization.yaml to ./config/configgen, and a kustomization.yaml to ./config/default that calls ../configgenThe code in this PR is experimental and probably won't merge for awhile.
/kind feature