Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update contributing guide to build successfully #210

Merged
merged 1 commit into from
May 25, 2018
Merged

Update contributing guide to build successfully #210

merged 1 commit into from
May 25, 2018

Conversation

font
Copy link
Contributor

@font font commented May 24, 2018

There are no template variables for GOOS and GOARCH in cloudbuild_local.yaml so this prevents the error:

2018/05/24 10:39:32 Error validating build: key "_GOOS" in the substitution data is not matched in the template;key "_GOARCH" in the substitution data is not matched in the template

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 24, 2018
kragniz
kragniz approved these changes May 24, 2018
View reviewed changes
Copy link
Contributor

@kragniz kragniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the same issue getting started

@pwittrock pwittrock merged commit 69bb4ac into kubernetes-sigs:master May 25, 2018
@pwittrock
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kragniz kragniz kragniz approved these changes

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@font @pwittrock @kragniz @k8s-ci-robot