📖 Update go Prerequisites for the latest release #2257

swiftslee · 2021-07-07T13:59:46Z

Signed-off-by: yuswift yuswift2018@gmail.com
Fixes #2207
As #2182 upgraded the go version to v1.16, the quickstart prerequisites need to be updated too.

k8s-ci-robot · 2021-07-07T13:59:54Z

Hi @yuswift. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

docs/book/src/quick-start.md

camilamacedo86 · 2021-07-11T18:27:05Z

docs/book/src/quick-start.md

@@ -9,7 +9,7 @@ This Quick Start guide will cover:

 ## Prerequisites

- [go](https://golang.org/dl/) version v1.15+ and < 1.16.
+- [go](https://golang.org/dl/) version 1.15+ and < 1.17.


We need to update it for 1.16+ < 1.17. IHMO
c/c @rashmigottipati could you look in the issue which is with you about this topic?
c/c @estroz @jmrodri

IMO, using go 1.15 is more suitable for kubebuilder v3.0. What about changing it to

- [go](https://golang.org/dl/) version v1.15+ and < 1.16(kubebuilder v3.0). - [go](https://golang.org/dl/) version v1.16 and < 1.17(kubebuilder v3.1).

The supported version is the version that is scaffolded. See: https://github.com/kubernetes-sigs/kubebuilder/blob/v3.0.0/testdata/project-v3/go.mod#L3
I agree with your suggestion. It seems fine.

Signed-off-by: yuswift <yuswift2018@gmail.com>

swiftslee · 2021-07-26T08:39:16Z

@camilamacedo86 hi could you add a comment /test all ? Thanks.

jmcshane · 2021-08-10T17:07:50Z

hey team, just wanted to put out a note about how important this PR is for the docs. I understand that the go version is reflected in the code, but to keep this out of date with the latest kubebuilder (especially when the book suggests you install the latest version https://book.kubebuilder.io/quick-start.html#installation) can cause a bit of an issue getting up and running with the project. appreciate your work here to keep things up to date.

estroz · 2021-08-10T18:27:20Z

I've refactored the go version check so versions are compared to plugin-specific requirements (#2290). There is no max version (less that 2.0 which will have breaking changes) since all 1.Y go versions will be forward-compatible, so you can remove the max one it merges.

swiftslee · 2021-08-11T00:31:07Z

I've refactored the go version check so versions are compared to plugin-specific requirements (#2290). There is no max version (less that 2.0 which will have breaking changes) since all 1.Y go versions will be forward-compatible, so you can remove the max one it merges.

Thanks. So, do I just need to keep the min one(e.g. v3.0->go 1.15+ v3.1-> go1.16+)?

estroz · 2021-08-11T00:49:24Z

Yep!

swiftslee · 2021-08-11T01:21:04Z

Yep!

awesome!

Signed-off-by: yuswift <yuswift2018@gmail.com>

swiftslee · 2021-08-12T00:11:38Z

@estroz hi, I updated the go version. Could you take a look at it? Thanks!

docs/book/src/quick-start.md

estroz · 2021-08-12T16:12:30Z

/ok-to-test

Co-authored-by: Eric Stroczynski <ericstroczynski@gmail.com>

estroz · 2021-08-13T04:52:13Z

/retest

estroz · 2021-08-13T04:52:29Z

/approve
/lgtm

k8s-ci-robot · 2021-08-13T04:52:46Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: estroz, yuswift

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [estroz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

swiftslee · 2021-08-18T11:39:43Z

@estroz Could we merge this pr?

estroz · 2021-08-18T15:05:12Z

/override coverage/coveralls

k8s-ci-robot · 2021-08-18T15:05:13Z

@estroz: Overrode contexts on behalf of estroz: coverage/coveralls

In response to this:

/override coverage/coveralls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

swiftslee · 2021-08-19T06:20:15Z

@estroz thanks for the review. BTW, how do we trigger rebuilding the books? The website is still not updated.

estroz · 2021-08-19T15:43:51Z

@yuswift typically on each release, the book-v3 branch gets updated. In this case it should be updated sooner. I'll get on that soon.

ping @camilamacedo86

rashmigottipati · 2021-08-19T16:16:55Z

@estroz I can help with that (if you'd like). Let me know what needs to be done to update the book.

* update go prerequisites for the latest release Signed-off-by: yuswift <yuswift2018@gmail.com> * remove the max goversion limit Signed-off-by: yuswift <yuswift2018@gmail.com> * Update docs/book/src/quick-start.md Co-authored-by: Eric Stroczynski <ericstroczynski@gmail.com> Co-authored-by: Eric Stroczynski <ericstroczynski@gmail.com>

* update go prerequisites for the latest release Signed-off-by: yuswift <yuswift2018@gmail.com> * remove the max goversion limit Signed-off-by: yuswift <yuswift2018@gmail.com> * Update docs/book/src/quick-start.md Co-authored-by: Eric Stroczynski <ericstroczynski@gmail.com> Co-authored-by: Eric Stroczynski <ericstroczynski@gmail.com> Co-authored-by: Swift <yuswift2018@gmail.com> Co-authored-by: Eric Stroczynski <ericstroczynski@gmail.com>

rashmigottipati · 2021-08-23T23:51:42Z

@yuswift
#2308 (cherry pick PR of doc fix was merged into the book-v3 branch), so the quickstart prerequisites in the website are now updated to below.

swiftslee · 2021-08-24T00:31:17Z

@yuswift
#2308 (cherry pick PR of doc fix was merged into the book-v3 branch), so the quickstart prerequisites in the website are now updated to below.

thanks!

* update go prerequisites for the latest release Signed-off-by: yuswift <yuswift2018@gmail.com> * remove the max goversion limit Signed-off-by: yuswift <yuswift2018@gmail.com> * Update docs/book/src/quick-start.md Co-authored-by: Eric Stroczynski <ericstroczynski@gmail.com> Co-authored-by: Eric Stroczynski <ericstroczynski@gmail.com> Co-authored-by: Swift <yuswift2018@gmail.com> Co-authored-by: Eric Stroczynski <ericstroczynski@gmail.com>

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 7, 2021

k8s-ci-robot requested review from droot and joelanford July 7, 2021 13:59

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 7, 2021

swiftslee mentioned this pull request Jul 7, 2021

kubebuilder fialed when I initialize a new project (go.mod file indicates go 1.16, but maximum supported version is 1.15) #2207

Closed

estroz reviewed Jul 7, 2021

View reviewed changes

docs/book/src/quick-start.md Outdated Show resolved Hide resolved

camilamacedo86 reviewed Jul 11, 2021

View reviewed changes

update go prerequisites for the latest release

8306b8f

Signed-off-by: yuswift <yuswift2018@gmail.com>

swiftslee force-pushed the fix_quickstart_prerequisites branch from 281e422 to 8306b8f Compare July 16, 2021 11:55

remove the max goversion limit

e84689b

Signed-off-by: yuswift <yuswift2018@gmail.com>

estroz reviewed Aug 12, 2021

View reviewed changes

docs/book/src/quick-start.md Outdated Show resolved Hide resolved

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 12, 2021

Update docs/book/src/quick-start.md

1d35039

Co-authored-by: Eric Stroczynski <ericstroczynski@gmail.com>

k8s-ci-robot assigned estroz Aug 13, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 13, 2021

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2021

swiftslee mentioned this pull request Aug 18, 2021

"kubebuilder init" command changed go 1.15 in go mod becomes 1.16 #2292

Closed

k8s-ci-robot merged commit cc270dd into kubernetes-sigs:master Aug 18, 2021

swiftslee deleted the fix_quickstart_prerequisites branch August 20, 2021 02:11

rashmigottipati mentioned this pull request Aug 20, 2021

📖 Update go Prerequisites for the latest release #2308

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

📖 Update go Prerequisites for the latest release #2257

📖 Update go Prerequisites for the latest release #2257

swiftslee commented Jul 7, 2021

k8s-ci-robot commented Jul 7, 2021

camilamacedo86 Jul 11, 2021 •

edited

Loading

swiftslee Jul 12, 2021

camilamacedo86 Jul 16, 2021

swiftslee Jul 16, 2021

swiftslee commented Jul 26, 2021

jmcshane commented Aug 10, 2021

estroz commented Aug 10, 2021 •

edited

Loading

swiftslee commented Aug 11, 2021

estroz commented Aug 11, 2021

swiftslee commented Aug 11, 2021

swiftslee commented Aug 12, 2021

estroz commented Aug 12, 2021

estroz commented Aug 13, 2021

estroz commented Aug 13, 2021

k8s-ci-robot commented Aug 13, 2021

swiftslee commented Aug 18, 2021

estroz commented Aug 18, 2021

k8s-ci-robot commented Aug 18, 2021

swiftslee commented Aug 19, 2021

estroz commented Aug 19, 2021

rashmigottipati commented Aug 19, 2021

rashmigottipati commented Aug 23, 2021

swiftslee commented Aug 24, 2021

📖 Update go Prerequisites for the latest release #2257

📖 Update go Prerequisites for the latest release #2257

Conversation

swiftslee commented Jul 7, 2021

k8s-ci-robot commented Jul 7, 2021

camilamacedo86 Jul 11, 2021 • edited Loading

Choose a reason for hiding this comment

swiftslee Jul 12, 2021

Choose a reason for hiding this comment

camilamacedo86 Jul 16, 2021

Choose a reason for hiding this comment

swiftslee Jul 16, 2021

Choose a reason for hiding this comment

swiftslee commented Jul 26, 2021

jmcshane commented Aug 10, 2021

estroz commented Aug 10, 2021 • edited Loading

swiftslee commented Aug 11, 2021

estroz commented Aug 11, 2021

swiftslee commented Aug 11, 2021

swiftslee commented Aug 12, 2021

estroz commented Aug 12, 2021

estroz commented Aug 13, 2021

estroz commented Aug 13, 2021

k8s-ci-robot commented Aug 13, 2021

swiftslee commented Aug 18, 2021

estroz commented Aug 18, 2021

k8s-ci-robot commented Aug 18, 2021

swiftslee commented Aug 19, 2021

estroz commented Aug 19, 2021

rashmigottipati commented Aug 19, 2021

rashmigottipati commented Aug 23, 2021

swiftslee commented Aug 24, 2021

camilamacedo86 Jul 11, 2021 •

edited

Loading

estroz commented Aug 10, 2021 •

edited

Loading