Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Build kubebuilder-tools for Kubernetes 1.22.1 and runtime 0.10.0 #2325

Closed

Conversation

hickeyma
Copy link
Contributor

@hickeyma hickeyma commented Sep 2, 2021

Signed-off-by: Martin Hickey martin.hickey@ie.ibm.com

This update of Kubernetes and controller-runtime helps fix envtest issues as raised in kubernetes-sigs/controller-runtime#1571. Thanks to @camilamacedo86 for helping me with this and @joelanford for his solution in operator-framework/helm-operator-plugins#102.

…0.9.6

Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 2, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hickeyma
To complete the pull request process, please assign adirio after the PR has been reviewed.
You can assign the PR to them by writing /assign @adirio in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hickeyma hickeyma changed the title 🌱 Build kubebuilder-tools for Kubernetes 1.22.1 and runtime 0.9.6 🌱 Build kubebuilder-tools for Kubernetes 1.22.1 and runtime 0.10.0 Sep 3, 2021
@hickeyma
Copy link
Contributor Author

hickeyma commented Sep 3, 2021

/retest

@hickeyma
Copy link
Contributor Author

hickeyma commented Sep 3, 2021

/test APIDiff / Verify API differences

@k8s-ci-robot
Copy link
Contributor

@hickeyma: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-kubebuilder-test
  • /test pull-kubebuilder-e2e-k8s-1-16-15
  • /test pull-kubebuilder-e2e-k8s-1-15-12
  • /test pull-kubebuilder-e2e-k8s-1-14-10

The following commands are available to trigger optional jobs:

  • /test pull-kubebuilder-e2e-k8s-1-19-4
  • /test pull-kubebuilder-e2e-k8s-1-18-8
  • /test pull-kubebuilder-e2e-k8s-1-17-11

Use /test all to run all jobs.

In response to this:

/test APIDiff / Verify API differences

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hickeyma
Copy link
Contributor Author

hickeyma commented Sep 3, 2021

/test all

Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
@estroz
Copy link
Contributor

estroz commented Sep 3, 2021

Only 1.22.0 tools exist (see #2287), so you'd have to specify that version in docs. Feel free to submit a tools-releases branch PR if you'd like to see 1.22.1 available though!

On second thought, this PR doesn't actually cover all the changes needed to bump k8s deps to 1.22. I'd prefer to see if older or newer 1.21 apiserver binaries do not have the hanging problem described in kubernetes-sigs/controller-runtime#1571 before moving to 1.22, since that change would be small.

@hickeyma
Copy link
Contributor Author

hickeyma commented Sep 6, 2021

Tested using the cronjob-tutorial, results as follows:

So, looks like issue in Kubernetes v1.21, v1.22.

@k8s-ci-robot
Copy link
Contributor

@hickeyma: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 9, 2021
@hickeyma
Copy link
Contributor Author

hickeyma commented Sep 9, 2021

@estroz I wonder should we close this PR considering it doesn't fix the envTest issue.

@estroz
Copy link
Contributor

estroz commented Sep 9, 2021

/close

@k8s-ci-robot
Copy link
Contributor

@estroz: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants