-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Build kubebuilder-tools for Kubernetes 1.22.1 and runtime 0.10.0 #2325
🌱 Build kubebuilder-tools for Kubernetes 1.22.1 and runtime 0.10.0 #2325
Conversation
…0.9.6 Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hickeyma The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/test APIDiff / Verify API differences |
@hickeyma: The specified target(s) for
The following commands are available to trigger optional jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test all |
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
c6fd0a4
to
d1b47ae
Compare
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
On second thought, this PR doesn't actually cover all the changes needed to bump k8s deps to 1.22. I'd prefer to see if older or newer 1.21 apiserver binaries do not have the hanging problem described in kubernetes-sigs/controller-runtime#1571 before moving to 1.22, since that change would be small. |
Tested using the cronjob-tutorial, results as follows:
So, looks like issue in Kubernetes v1.21, v1.22. |
@hickeyma: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@estroz I wonder should we close this PR considering it doesn't fix the envTest issue. |
/close |
@estroz: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Martin Hickey martin.hickey@ie.ibm.com
This update of Kubernetes and controller-runtime helps fix envtest issues as raised in kubernetes-sigs/controller-runtime#1571.Thanks to @camilamacedo86 for helping me with this and @joelanford for his solution in operator-framework/helm-operator-plugins#102.