-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Plugin phase 2 implementation #2338
✨Plugin phase 2 implementation #2338
Conversation
@rashmigottipati: GitHub didn't allow me to request PR reviews from the following users: jmrodri. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cd004f4
to
6c88396
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First round pass is done. I'll take another look after you've address Eric's and my comments.
eb2184d
to
00272bf
Compare
00272bf
to
82466b9
Compare
2977788
to
43df417
Compare
43df417
to
ebdd9d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is pretty close to done. I'd like to see a bunch of unit tests and 1 e2e test using the POC code prior to merging.
@camilamacedo86 I'll be on PTO next week so if you could review/approve/lgtm this PR that'd be awesome!
ebdd9d7
to
72d3a51
Compare
@estroz thanks a lot for the review. Will work on adding some unit tests and 1 e2e test and update the PR when done. |
7369051
to
fa8651e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rashmigottipati could we squash the commits and fix the lint issues?
See that make lint-fix might help you out here.
fa8651e
to
72bc7c1
Compare
e8f2ae4
to
bc163d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rashmigottipati,
Some nits for now and follow up : https://github.com/kubernetes-sigs/kubebuilder/pull/2338/files#r872547809
2fc1502
to
f74628f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a terrific work 🥇
I loved your sample .. We must have the python plugin here. That is amazing
/approved
/lgtm
/hold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, rashmigottipati The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add discovery of external plugins Define external plugin interface Add subcommands functionality for init, create api, createa webhook, edit Add unit tests for Discovery and Scaffold functions Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>
f74628f
to
2fe045d
Compare
/hold cancel /lgtm |
a description of the change
Adds implementation to discover and run external plugins in a chained manner.
the motivation for the change
Phase 2 Design Proposal