Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Remove deprecated go get from Makefile templates #2486

Merged
merged 1 commit into from
Mar 15, 2022

Commits on Mar 10, 2022

  1. Remove deprecated go get from Makefile templates

    Signed-off-by: Ryan King <ryking@redhat.com>
    
    In go 1.18, using `go get` to install go binaries will be removed from
    in favor of using `go install`. This commit updates the Makefile
    templates to use alternative installation methods to install the tools
    used at generation.
    
    Since `go install` adds extra constraints on what go packages can be
    installed, not all tools were a simple `go get` => `go install` change:
    
    - `kustomize`: Incompatible with `go install` because its `go.mod` has
    `exclude` and `replace` directives. The template now uses the official
    install script.
    - `controller-gen`: Fully compatible with `go install`.
    - `setup-envtest`: Can be installed using `go install`, but not a
    specific version since the repo does not have the tag scheme since it is
    in a sub-module. It would need a tag in the format
    `tools/setup-envtest/vX.Y.Z`.
    
    The commit also regenerated all book source code using this new pattern.
    ryantking committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    b0c7cd8 View commit details
    Browse the repository at this point in the history