Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃摉 update prerequisites to clarifies go versions which are supported #2548

Closed
wants to merge 1 commit into from

Conversation

camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented Mar 18, 2022

Description
馃摉 Update go version information in the QuickStart Prerequisites

Motivation
Closes: #2543

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 18, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2022
@coderanger
Copy link

-1 on making this so specific. We can certainly recommend versions that are tested with but I don't think this reflects the reality of what versions are supported.

@camilamacedo86
Copy link
Member Author

camilamacedo86 commented Mar 21, 2022

Hi @coderanger,

We can only support these specific versions. We do not test all ensure it with all versions.
Unfortunately, the project does not work in many scenarios when users do not use the supported Golang versions since it has break changes. E.g. Go 1.18 will not work with the latest release at all since go get was deprecated and no longer available in 1.18. KB and SDK never provided support to a big matrix and we only officially supported one Golang version per release always. But from golang1.13 to 1.15 ( e.g.), we were not impacted which is not the case with these latest Golang releases.

These are the versions that we can support now, however, users still able to use any other version as please them.
We just need to clarify how it works currently. But we are open to any proposal for a design solution that would allow us to support a bigger matrix of go versions in the future as well. Then, IHMO that needs to be proposed via doc design where will be highlighted how we will achieve and ensure it.

So examples of the issues and scenarios to illustrate it:

I hope that clarifies.

@AlmogBaku
Copy link
Member

I'm with @camilamacedo86 here. Declaring the versions which are supported means that this is what the team has identified as potentially broken. You are always welcome to challenge it, but this is not what we recommend.

/lgtm

@k8s-ci-robot
Copy link
Contributor

@AlmogBaku: changing LGTM is restricted to collaborators

In response to this:

I'm with @camilamacedo86 here. Declaring the versions which are supported means that this is what the team has identified as potentially broken. You are always welcome to challenge it, but this is not what we recommend.

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlmogBaku, camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@camilamacedo86
Copy link
Member Author

By thinking deeper here.
Why we are adding the min/ max go version for each bin released?
In the doc we try to keep the state/info only about the latest release/master

So, that makes no sense. We actually should only have now GO >= 17 and <=18
We are bumping GO 1.18 so we might solve this scenario.

c/c @AlmogBaku

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"kubebuilder create api" does not work with Go 1.18
4 participants