-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 fix run unit test locally #2581
🌱 fix run unit test locally #2581
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After investigating further, I found another issue that causing this:
/pkg/cli/alpha/config-gen/testdata/project
is missing a go module. Creating a module there solves the problem/pkg/cli/alpha/config-gen/controller-gen-filer.go:L67
ignoring a critical issue
Since this is especially breaking since go 1.18, I'll add this fix as part of my PR
/hold |
/hold cancel |
/hold I'd like to |
Description
🌱 fix run unit test and coverage test by removing the race flag
Why?
The tests implemented for the config-gen alpha command are not working locally with this option:
E.g the above was using (mac os/amd64) besides working on the ci.
We might need to look for how to come back to the -race option in the future. (I'd suggest seeing if we can migrate alpha-gen to the plugin first)
This pr unblocks contributors that want to run the tests locally.
Closes; #2567