Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add string method for ReconcileKey #26

Merged
merged 1 commit into from
Mar 29, 2018
Merged

Add string method for ReconcileKey #26

merged 1 commit into from
Mar 29, 2018

Conversation

natronq
Copy link
Contributor

@natronq natronq commented Mar 23, 2018

For better display in log statements e.g.

glog.Infof("Implement reconcile for '%s'.\n", k)
-> Implement reconcile for namespace/object

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 23, 2018
@pwittrock pwittrock merged commit a52d0ee into kubernetes-sigs:master Mar 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@natronq @pwittrock @k8s-ci-robot