🌱 Prepare for release 3.4.0 #2643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove namespace from ClusterRoleBinding
Also updated old prerequisites for better clarity. Co-authored-by: Camila Macedo <7708031+camilamacedo86@users.noreply.github.com>
…versioning 📖 Fix broken links to CLI plugin versioning
📖 Update go prerequisites for the 3.3 release
📖 Remove namespace from ClusterRoleBinding
🌱 Add script for checking licenses
Co-authored-by: Camila Macedo <7708031+camilamacedo86@users.noreply.github.com>
🐛 fix issue to scaffold same Kind for different groups with multi-group support by using group name in crd/patches and rbac editor/viewer manifests
Co-authored-by: Camila Macedo <7708031+camilamacedo86@users.noreply.github.com>
📖 Fix link for component-config-tutorial
We need to copy the channels directory in the Dockerfile, particularly now that we're running with non-root permissions and it is no longer a one-liner. Signed-off-by: Vivek Singh <svivekkumar@vmware.com>
Fix incomplete instruction for validating webhook.
More and more users are now using M1 chips for development so publishing kubebuilder-tools in darwin/arm64 arch will enable them to use the project natively on their machines without needing to apply custom ways of solving missing dependencies. Addresses #2505 Signed-off-by: dntosas <ntosas@gmail.com>
📖 Fix incomplete instruction for validating webhook
✨ : Generate Dockerfile from declarative plugin
…images ✨ [build] Add support for darwin/arm64 arch
Signed-off-by: Daniel Hu <tao.hu@merico.dev>
📖Add info about markers
📖 Fix link for ControllerManagerConfigurationSpec
📖 fix typo in DESIGN.md doc
Signed-off-by: Ryan King <ryking@redhat.com> In go 1.18, using `go get` to install go binaries will be removed from in favor of using `go install`. This commit updates the Makefile templates to use alternative installation methods to install the tools used at generation. Since `go install` adds extra constraints on what go packages can be installed, not all tools were a simple `go get` => `go install` change: - `kustomize`: Incompatible with `go install` because its `go.mod` has `exclude` and `replace` directives. The template now uses the official install script. - `controller-gen`: Fully compatible with `go install`. - `setup-envtest`: Can be installed using `go install`, but not a specific version since the repo does not have the tag scheme since it is in a sub-module. It would need a tag in the format `tools/setup-envtest/vX.Y.Z`. The commit also regenerated all book source code using this new pattern.
This commit fix link for CRD-version-pref.
🌱Made changes to prevent golanci-lint failing
📖 Fix doc link for CRD-version-pref
📖 fix minor misspelling issue
📖 add info in docs: go version v1.18+ has not been supported yet
k8s-ci-robot
added
size/XXL
|
Hi @ryantking. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
cncf-cla: yes
Closed
|
/approved Great 🥇 |
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
/approved |
camilamacedo86
approved these changes
Apr 28, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, ryantking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm Holding up the PR in case anyone else would like to take a look. Feel free to unhold @camilamacedo86. |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add latest commits from
mastertorelease-3Closes: #2644