Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 GIT-2731: enable TokenRequest for ServiceAccount token generation #2733

Merged
merged 1 commit into from
Jun 20, 2022
Merged

🌱 GIT-2731: enable TokenRequest for ServiceAccount token generation #2733

merged 1 commit into from
Jun 20, 2022

Conversation

harshanarayana
Copy link
Contributor

Closes #2731

This addresses #2723 (comment)

Move to using an explicit Token generated for the SA by invoking the kubectl create token command.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 16, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @harshanarayana!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 16, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @harshanarayana. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@harshanarayana harshanarayana force-pushed the ut/GIT-2731-enhance-sa-token-request branch 2 times, most recently from ee4b478 to e07a05d Compare June 16, 2022 06:47
@camilamacedo86
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 16, 2022
@harshanarayana harshanarayana changed the title 🐛 GIT-2731: enable TokenRequest for ServiceAccount token generation 🌱 GIT-2731: enable TokenRequest for ServiceAccount token generation Jun 16, 2022
@harshanarayana harshanarayana force-pushed the ut/GIT-2731-enhance-sa-token-request branch from e07a05d to 1149e17 Compare June 16, 2022 12:10
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 16, 2022
@harshanarayana
Copy link
Contributor Author

/retest

@harshanarayana
Copy link
Contributor Author

🤦 Broken indentation causing test failure. Let me fix.

@harshanarayana harshanarayana force-pushed the ut/GIT-2731-enhance-sa-token-request branch from 1149e17 to 6965ce4 Compare June 16, 2022 15:41
@harshanarayana
Copy link
Contributor Author

/test pull-kubebuilder-e2e-k8s-1-18-20

@harshanarayana
Copy link
Contributor Author

/retest

@harshanarayana
Copy link
Contributor Author

/test pull-kubebuilder-e2e-k8s-1-19-16

@harshanarayana harshanarayana force-pushed the ut/GIT-2731-enhance-sa-token-request branch from 6965ce4 to 9c8a1e8 Compare June 16, 2022 17:14
@harshanarayana
Copy link
Contributor Author

/test pull-kubebuilder-e2e-k8s-1-19-16

@harshanarayana
Copy link
Contributor Author

NOTE

had to make a hacky change to the setup.sh to make it switch between the right kind config file based on versions. kind config for 1.18 and 1.19 are the same file. kind-config-v1.19.yaml is just a symlink to kind-config-v1.18.yaml

These two files introduce new Argument to the API Server to make sure the TokenRequest will work.

@harshanarayana harshanarayana marked this pull request as ready for review June 16, 2022 17:31
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 16, 2022
@harshanarayana
Copy link
Contributor Author

/cc @camilamacedo86 @everettraven @liggitt

@k8s-ci-robot
Copy link
Contributor

@harshanarayana: GitHub didn't allow me to request PR reviews from the following users: everettraven.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @camilamacedo86 @everettraven @liggitt

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@harshanarayana harshanarayana force-pushed the ut/GIT-2731-enhance-sa-token-request branch 2 times, most recently from 5a7d2e0 to 9d02513 Compare June 18, 2022 16:49
camilamacedo86
camilamacedo86 approved these changes Jun 19, 2022
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That shows great 🥇

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2022
everettraven
everettraven approved these changes Jun 19, 2022
View reviewed changes
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks so much for the contribution @harshanarayana!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, everettraven, harshanarayana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@harshanarayana harshanarayana force-pushed the ut/GIT-2731-enhance-sa-token-request branch from 9d02513 to 27e0d3a Compare June 19, 2022 14:22
@camilamacedo86
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2022
@k8s-ci-robot k8s-ci-robot merged commit 8ec681a into kubernetes-sigs:master Jun 20, 2022
@everettraven everettraven mentioned this pull request Jun 24, 2022
Closed
9 tasks
@harshanarayana harshanarayana mentioned this pull request Sep 13, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@everettraven everettraven everettraven approved these changes

@joelanford joelanford Awaiting requested review from joelanford

@pwittrock pwittrock Awaiting requested review from pwittrock

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@camilamacedo86 camilamacedo86

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

testing: improve token usage in e2e tests
4 participants
@harshanarayana @k8s-ci-robot @camilamacedo86 @everettraven