✨ (kustomize/v2-alpha) fixes in the scaffold to follow the changes in the MAJOR release of kustomize

[camilamacedo86]

Description

• Replace every instance of $(SOMETHING) with any arbitrary placeholder value.
• Replace: bases: with resources:
• Replace:

#  someName: someValue

With:

#labels:
#- includeSelectors: true
#  pairs:
#    someName: someValue

[k8s-ci-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[camilamacedo86]

/test all

[camilamacedo86]

/test all

[camilamacedo86]

/test all

[erikgb]

IMO the suffix _PLACEHOLDER is not needed. The all-caps style is easily recognized as var-syntax style IMO.

But I wonder if this change really work? Have you tested the resulting scaffolding @camilamacedo86? If you are trying to migrate from using vars to replacements, I think there is a bit more to be done, ref. https://kubectl.docs.kubernetes.io/references/kustomize/kustomization/vars/#more-complex-migration-example

[camilamacedo86]

Hi @erikgb this changes are for the new alpha plugin. (alpha and not in the default scaffild)

The changes from vars to replacements are done here: https://github.com/kubernetes-sigs/kubebuilder/blob/master/pkg/plugins/common/kustomize/v2/scaffolds/internal/templates/config/kdefault/kustomization.go#L92-L190
In this follow-up pr, I am just trying to adjust the rest of the places.

Why did I change the var by the placeholders? The doc says:

Replace every instance of $(SOME_SECRET_NAME) with any arbitrary placeholder value.

Anyway, if we do not do this replacement it still working because as you can see in the kustomize config where the replacements are used we are working with positions.

The kustomize changes on the alpha one have been tested in the e2e here : https://github.com/kubernetes-sigs/kubebuilder/blob/master/test/e2e/v3/plugin_cluster_test.go#L132-L151

However, we will still be needing other follow-ups and address further changes to the new alpha plugin ONLY.

[erikgb]

Ok, I understand that the migration to replacements has started. Good! But I would just stick with the existing names SERVICE_NAME \ SERVICE_NAMESPACE and drop the _PLACEHOLDER postfix. It still looks like a placeholder IMO.

[camilamacedo86]

@erikgb : If we run kustomize edit fix --vars to help you move forward with the new changes for 4.x they suggest PLACEHOLDER word to make clear for users that it is just a PLACEHOLDER so because of that I kept as suggested but yep I think we can remove the word

[everettraven]

Looks good to me!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, everettraven

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[camilamacedo86]

Moving forward since the @erikgb suggestions are addressed and we have also another LGTM.